Issue 4529110: code review 4529110: big: remove some unnecessary conversions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4529110: code review 4529110: big: remove some unnecessary conversions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by gri

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

big: remove some unnecessary conversions

Patch Set 1 #

Patch Set 2 : diff -r f6456892edff https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f6456892edff https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f6456892edff https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f6456892edff https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r d27c5e1bd8e4 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -42 lines)			Patch
M	src/pkg/big/arith.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/big/arith_386.s	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/big/arith_amd64.s	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/big/arith_arm.s	View	1	6 chunks	+9 lines, -3 lines	0 comments	Download
M	src/pkg/big/arith_decl.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/big/arith_test.go	View	1	2 chunks	+15 lines, -4 lines	0 comments	Download
M	src/pkg/big/nat.go	View	1 2 3 4 5	6 chunks	+22 lines, -21 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-06-02 18:58:22 UTC) #1

gri

13 years, 11 months ago (2011-06-02 19:58:31 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=895ddf3d55bd ***

big: remove some unnecessary conversions

R=rsc
CC=golang-dev
http://codereview.appspot.com/4529110

Expand All Messages | Collapse All Messages