Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(550)

Issue 4527077: Mask modifier: mask by radius

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by jesterKing
Modified:
12 years, 12 months ago
Reviewers:
bf-codereview, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender
Visibility:
Public.

Description

This patch adds the radius masking capability to the mask modifier: everything outside the radius gets masked out.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
release/scripts/startup/bl_ui/properties_data_modifier.py View 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/makesdna/DNA_modifier_types.h View 2 chunks +4 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_modifier.c View 3 chunks +8 lines, -0 lines 1 comment Download
source/blender/modifiers/intern/MOD_mask.c View 3 chunks +33 lines, -1 line 0 comments Download
source/blender/modifiers/intern/MOD_util.c View 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 3
jesterKing
12 years, 12 months ago (2011-05-24 21:05:14 UTC) #1
jesterKing
I had set the bf-codereview@blender.org wrong, so here a reply to notify that this patch ...
12 years, 12 months ago (2011-05-25 08:04:52 UTC) #2
brechtvl
12 years, 12 months ago (2011-05-25 10:43:09 UTC) #3
I was expecting the option to use an object to specify the center of the mask,
though that probably depends on the use case, I don't know what this modifier is
typically used for.

The radius should be initialized to e.g. 1.0 instead of 0.0, adding an initData
callback in MOD_mask.c and version patch in readfile.c.

http://codereview.appspot.com/4527077/diff/1/source/blender/makesrna/intern/r...
File source/blender/makesrna/intern/rna_modifier.c (right):

http://codereview.appspot.com/4527077/diff/1/source/blender/makesrna/intern/r...
source/blender/makesrna/intern/rna_modifier.c:2134:
RNA_def_property_ui_text(prop, "Radius", "Maskin radius");
Maskin -> Masking

http://codereview.appspot.com/4527077/diff/1/source/blender/modifiers/intern/...
File source/blender/modifiers/intern/MOD_util.c (right):

http://codereview.appspot.com/4527077/diff/1/source/blender/modifiers/intern/...
source/blender/modifiers/intern/MOD_util.c:162: (*texco)[1] =
(*texco)[1]*2.f-1.f;
This extra mapping mode isn't mentioned in the summary, is it intended to be
included in the patch?

In any case, (*texco)[2] should not be left uninitialized.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b