Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1241)

Issue 4526094: Allows accidental placements to be individualized. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by MikeSol
Modified:
12 years, 11 months ago
Reviewers:
mike, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

A note-column can have individualized accidental placements, which help with harmonic suggestions.

Patch Set 1 : Allows accidental placements to be individualized. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M lily/accidental-engraver.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M lily/accidental-placement.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M lily/note-head.cc View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
MikeSol
Hey all, This, in combination with my stem-attachment patch, allows for the small notes above ...
12 years, 11 months ago (2011-06-04 12:50:55 UTC) #1
Neil Puttock
On 2011/06/04 12:50:55, MikeSol wrote: > This, in combination with my stem-attachment patch, allows for ...
12 years, 11 months ago (2011-06-04 15:16:18 UTC) #2
mike_apollinemike.com
12 years, 11 months ago (2011-06-05 10:18:10 UTC) #3
On Jun 4, 2011, at 5:16 PM, n.puttock@gmail.com wrote:

> On 2011/06/04 12:50:55, MikeSol wrote:
> 
>> This, in combination with my stem-attachment patch, allows for the
> small notes
>> above harmonics that give the sounding pitch to be typset well.
> 
> I think you should consider making the sounding pitch a separate
> constellation of grobs, similar to a pitched trill.  This has the
> benefit of not needing slightly naughty hacks to kill stem attachments.
> :)
> 
> \relative c' {
>  \override TrillPitchGroup #'X-offset = #0
>  \override TrillSpanner #'stencil = ##f
>  \pitchedTrill
>  <as des\harmonic >\startTrillSpan des''
> }
> 
> Cheers,
> Neil


Brilliant!  I'll nix my patch for the stem attachments, then (the only reason I
needed it was to typeset harmonics).

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b