code review 4526073: crypto/x509: fix incorrect prints found by govet

crypto/x509: fix incorrect prints found by govet

[rh, 2011-05-21 23:20:47]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-05-21 23:22:51]

LGTM

On Sat, May 21, 2011 at 4:20 PM, <robert.hencke@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> crypto/x509: fix incorrect prints found by govet
>
> Please review this at http://codereview.appspot.com/4526073/
>
> Affected files:
>  M src/pkg/crypto/x509/x509_test.go
>
>
> Index: src/pkg/crypto/x509/x509_test.go
> ===================================================================
> --- a/src/pkg/crypto/x509/x509_test.go
> +++ b/src/pkg/crypto/x509/x509_test.go
> @@ -313,7 +313,7 @@
>        pemBlock, _ := pem.Decode([]byte(dsaCertPem))
>        cert, err := ParseCertificate(pemBlock.Bytes)
>        if err != nil {
> -               t.Fatal("Failed to parse certificate: %s", err)
> +               t.Fatalf("Failed to parse certificate: %s", err)
>        }
>        if cert.SignatureAlgorithm != DSAWithSHA1 {
>                t.Errorf("Parsed signature algorithm was not DSAWithSHA1")
> @@ -324,10 +324,10 @@
>        pemBlock, _ := pem.Decode([]byte(dsaCertPem))
>        cert, err := ParseCertificate(pemBlock.Bytes)
>        if err != nil {
> -               t.Fatal("Failed to parse certificate: %s", err)
> +               t.Fatalf("Failed to parse certificate: %s", err)
>        }
>        // test cert is self-signed
>        if err = cert.CheckSignatureFrom(cert); err != nil {
> -               t.Fatal("DSA Certificate verfication failed: %s", err)
> +               t.Fatalf("DSA Certificate verfication failed: %s", err)
>        }
>  }
>
>
>

[r, 2011-05-21 23:22:54]

LGTM

[r, 2011-05-21 23:23:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=541046ce7b30 ***

crypto/x509: fix incorrect prints found by govet

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4526073

Committer: Rob Pike <r@golang.org>