Issue 4526044: code review 4526044: gif: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4526044: code review 4526044: gif: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by r

Modified:
14 years ago

Reviewers:
nigeltao_gnome

CC:
nigeltao, golang-dev

Visibility:
Public.

gif: fix build Had bit test wrong on transparency; no excuses.

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/image/gif/reader.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

Hello nigeltao (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-09 13:37:48 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=aea0ba6e5935 *** gif: fix build Had bit test wrong on transparency; no ...

14 years ago (2011-05-09 13:38:11 UTC) #2

nigeltao_gnome

14 years ago (2011-05-09 18:13:22 UTC) #3

LGTM.

On 9 May 2011 06:38,  <r@golang.org> wrote:
> gif: fix build
> Had bit test wrong on transparency; no excuses.