Issue 4524090: [google]Backport r174549 Fix 3 test cases incorrectly run in Thumb/Xscale

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by jingyu

Modified:
9 years, 8 months ago

Reviewers:
dougkwan, carrot

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/gcc/testsuite/

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -0 lines)			Patch
M	gcc.target/arm/g2.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gcc.target/arm/mmx-1.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gcc.target/arm/scd42-2.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jingyu

http://gcc.gnu.org/ml/gcc-patches/2010-10/msg00134.html Backport r174549 to fix three testcases that are specific to ARM mode and therefore ...

12 years, 11 months ago (2011-06-02 04:51:20 UTC) #1

http://gcc.gnu.org/ml/gcc-patches/2010-10/msg00134.html
Backport r174549 to fix three testcases that are specific to ARM mode
and therefore should be skipped when compiling for thumb.

Thanks,
Jing

2011-06-01  Jing Yu  <jingyu@google.com>
	Backport r174549

	2011-06-01  Sofiane Naci  <sofiane.naci@arm.com>

	* gcc.target/arm/mmx-1.c: Skip test in -mthumb.
	* gcc.target/arm/g2.c: Skip test in -mthumb.
	Skip test unless cpu is xscale.
	* gcc.target/arm/scd42-2.c: Likewise.

Index: gcc.target/arm/mmx-1.c
===================================================================
--- gcc.target/arm/mmx-1.c	(revision 174299)
+++ gcc.target/arm/mmx-1.c	(working copy)
@@ -4,6 +4,7 @@
 /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mcpu=*" } {
"-mcpu=iwmmxt" } } */
 /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mabi=*" } {
"-mabi=iwmmxt" } } */
 /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-march=*" } {
"-march=iwmmxt" } } */
+/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { ""
} } */
 /* { dg-options "-O -mno-apcs-frame -mcpu=iwmmxt -mabi=iwmmxt" } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-require-effective-target arm_iwmmxt_ok } */
Index: gcc.target/arm/g2.c
===================================================================
--- gcc.target/arm/g2.c	(revision 174299)
+++ gcc.target/arm/g2.c	(working copy)
@@ -2,6 +2,8 @@
 /* { dg-do compile } */
 /* { dg-options "-mcpu=xscale -O2" } */
 /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" } {
"-march=xscale" } } */
+/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } {
"-mcpu=xscale" } } */
+/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { ""
} } */
 /* { dg-require-effective-target arm32 } */
 
 /* Brett Gaines' test case. */
Index: gcc.target/arm/scd42-2.c
===================================================================
--- gcc.target/arm/scd42-2.c	(revision 174299)
+++ gcc.target/arm/scd42-2.c	(working copy)
@@ -2,6 +2,8 @@
 /* { dg-do compile } */
 /* { dg-options "-mcpu=xscale -O" } */
 /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" } {
"-march=xscale" } } */
+/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } {
"-mcpu=xscale" } } */
+/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { ""
} } */
 /* { dg-require-effective-target arm32 } */
 
 unsigned load2(void) __attribute__ ((naked));

--
This patch is available for review at http://codereview.appspot.com/4524090

carrot

12 years, 11 months ago (2011-06-02 20:52:34 UTC) #2

OK for google/main.

thanks
Carrot

On Thu, Jun 2, 2011 at 12:51 PM, Jing Yu <jingyu@google.com> wrote:
> http://gcc.gnu.org/ml/gcc-patches/2010-10/msg00134.html
> Backport r174549 to fix three testcases that are specific to ARM mode
> and therefore should be skipped when compiling for thumb.
>
> Thanks,
> Jing
>
> 2011-06-01  Jing Yu  <jingyu@google.com>
>        Backport r174549
>
>        2011-06-01  Sofiane Naci  <sofiane.naci@arm.com>
>
>        * gcc.target/arm/mmx-1.c: Skip test in -mthumb.
>        * gcc.target/arm/g2.c: Skip test in -mthumb.
>        Skip test unless cpu is xscale.
>        * gcc.target/arm/scd42-2.c: Likewise.
>
> Index: gcc.target/arm/mmx-1.c
> ===================================================================
> --- gcc.target/arm/mmx-1.c      (revision 174299)
> +++ gcc.target/arm/mmx-1.c      (working copy)
> @@ -4,6 +4,7 @@
>  /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mcpu=*" } {
"-mcpu=iwmmxt" } } */
>  /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mabi=*" } {
"-mabi=iwmmxt" } } */
>  /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-march=*" }
{ "-march=iwmmxt" } } */
> +/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } {
"" } } */
>  /* { dg-options "-O -mno-apcs-frame -mcpu=iwmmxt -mabi=iwmmxt" } */
>  /* { dg-require-effective-target arm32 } */
>  /* { dg-require-effective-target arm_iwmmxt_ok } */
> Index: gcc.target/arm/g2.c
> ===================================================================
> --- gcc.target/arm/g2.c (revision 174299)
> +++ gcc.target/arm/g2.c (working copy)
> @@ -2,6 +2,8 @@
>  /* { dg-do compile } */
>  /* { dg-options "-mcpu=xscale -O2" } */
>  /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" }
{ "-march=xscale" } } */
> +/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } {
"-mcpu=xscale" } } */
> +/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } {
"" } } */
>  /* { dg-require-effective-target arm32 } */
>
>  /* Brett Gaines' test case. */
> Index: gcc.target/arm/scd42-2.c
> ===================================================================
> --- gcc.target/arm/scd42-2.c    (revision 174299)
> +++ gcc.target/arm/scd42-2.c    (working copy)
> @@ -2,6 +2,8 @@
>  /* { dg-do compile } */
>  /* { dg-options "-mcpu=xscale -O" } */
>  /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" }
{ "-march=xscale" } } */
> +/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } {
"-mcpu=xscale" } } */
> +/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } {
"" } } */
>  /* { dg-require-effective-target arm32 } */
>
>  unsigned load2(void) __attribute__ ((naked));
>
> --
> This patch is available for review at http://codereview.appspot.com/4524090
>

Expand All Messages | Collapse All Messages