Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(412)

Issue 4523061: [google] support for building Linux kernel with FDO

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by xur
Modified:
14 years ago
Reviewers:
richard.guenther, bonzini, andi, davidxl
CC:
gcc-patches_gcc.gnu.org, hubicka_ucw.cz
Base URL:
svn://gcc.gnu.org/svn/gcc/branches/google/main/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1011 lines, -402 lines) Patch
M gcc/coverage.c View 2 chunks +9 lines, -0 lines 0 comments Download
M gcc/gcov-io.h View 6 chunks +97 lines, -4 lines 0 comments Download
M gcc/gcov-io.c View 12 chunks +141 lines, -7 lines 0 comments Download
M gcc/libgcov.c View 15 chunks +749 lines, -382 lines 0 comments Download
M gcc/tree-profile.c View 8 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 20
xur
This patch add support to build Linux kernel with FDO. Building Linux kernel with FDO ...
14 years ago (2011-05-13 01:03:40 UTC) #1
davidxl
Ok for google/main. David On Thu, May 12, 2011 at 6:03 PM, Rong Xu <xur@google.com> ...
14 years ago (2011-05-13 04:53:38 UTC) #2
richard.guenther_gmail.com
On Fri, May 13, 2011 at 6:53 AM, Xinliang David Li <davidxl@google.com> wrote: > Ok ...
14 years ago (2011-05-13 09:08:36 UTC) #3
hubicka_ucw.cz
> On Fri, May 13, 2011 at 6:53 AM, Xinliang David Li <davidxl@google.com> wrote: > ...
14 years ago (2011-05-13 09:43:44 UTC) #4
bonzini_gnu.org
On 05/13/2011 03:03 AM, Rong Xu wrote: > * gcc/coverage.c (revision 173717): set a flag ...
14 years ago (2011-05-13 12:54:11 UTC) #5
andi_firstfloor.org
On Fri, May 13, 2011 at 11:43:42AM +0200, Jan Hubicka wrote: > > On Fri, ...
14 years ago (2011-05-13 15:58:24 UTC) #6
davidxl
On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini <bonzini@gnu.org> wrote: > On 05/13/2011 ...
14 years ago (2011-05-13 16:31:20 UTC) #7
bonzini_gnu.org
On 05/13/2011 06:31 PM, Xinliang David Li wrote: >> > 1) add a new TLS ...
14 years ago (2011-05-13 16:42:42 UTC) #8
xur
Thanks for the comments. This particular patch is not intended for trunk. But we do ...
14 years ago (2011-05-13 18:44:42 UTC) #9
xur
Thanks for the comments. This particular patch is not intended for trunk. But we do ...
14 years ago (2011-05-13 18:45:31 UTC) #10
xur
Here is the kernel part of change (for kernel 2.6.36) -- just for the reference. ...
14 years ago (2011-05-13 18:59:14 UTC) #11
hubicka_ucw.cz
> On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini <bonzini@gnu.org> wrote: > > ...
14 years ago (2011-05-15 10:27:54 UTC) #12
davidxl
Agreed. David On Sun, May 15, 2011 at 3:27 AM, Jan Hubicka <hubicka@ucw.cz> wrote: >> ...
14 years ago (2011-05-16 21:00:24 UTC) #13
andi_firstfloor.org
Jan Hubicka <hubicka@ucw.cz> writes: > Yep, > I think it does make sense to share ...
14 years ago (2011-05-16 22:39:28 UTC) #14
xur
On Mon, May 16, 2011 at 3:38 PM, Andi Kleen <andi@firstfloor.org> wrote: > Jan Hubicka ...
14 years ago (2011-05-16 22:56:12 UTC) #15
davidxl
On Mon, May 16, 2011 at 3:38 PM, Andi Kleen <andi@firstfloor.org> wrote: > Jan Hubicka ...
14 years ago (2011-05-16 23:04:24 UTC) #16
hubicka_ucw.cz
> On Mon, May 16, 2011 at 3:38 PM, Andi Kleen <andi@firstfloor.org> wrote: > > ...
14 years ago (2011-05-16 23:13:05 UTC) #17
andi_firstfloor.org
Rong Xu <xur@google.com> writes: >> The current kernel code is for gcc 3. That could ...
14 years ago (2011-05-16 23:23:48 UTC) #18
xur
On Sun, May 15, 2011 at 3:27 AM, Jan Hubicka <hubicka@ucw.cz> wrote: >> On Fri, ...
14 years ago (2011-05-16 23:25:03 UTC) #19
xur
14 years ago (2011-05-16 23:32:15 UTC) #20
That will be good.
But you never know, we internally have fixed some bugs that filed to
us because people use kernel's old gcov code (many versions guarded by
ifdef) for their tests.

-Rong

On Mon, May 16, 2011 at 4:23 PM, Andi Kleen <andi@firstfloor.org> wrote:
> Rong Xu <xur@google.com> writes:
>
>>> The current kernel code is for gcc 3. That could be simply
>>> replaced with a modern gcc 4 interface.
>>
>> You cannot replace. You have to keep the code for every gcc versions
>> that being used.
>
> I don't think it's a problem to not support gcc 3 gcov/profiling
> anymore.
>
> -Andi
>
> --
> ak@linux.intel.com -- Speaking for myself only
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b