Issue 4521064: code review 4521064: crypto/openpgp: change PublicKey.Serialize to include t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4521064: code review 4521064: crypto/openpgp: change PublicKey.Serialize to include t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by agl1

Modified:
14 years ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

crypto/openpgp: change PublicKey.Serialize to include the header. Signature.Serialize already does this and they should be consistent.

Patch Set 2 : diff -r 5147cc4a249c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5147cc4a249c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5147cc4a249c https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 7ffedf93f1b3 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 7ffedf93f1b3 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -12 lines)			Patch
M	src/pkg/crypto/openpgp/packet/packet.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/openpgp/packet/public_key.go	View	1	4 chunks	+27 lines, -6 lines	0 comments	Download
M	src/pkg/crypto/openpgp/packet/public_key_test.go	View	1	2 chunks	+34 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/openpgp/packet/signature.go	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-13 21:00:06 UTC) #1

agl1

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-05-13 21:00:42 UTC) #2

bradfitz

LGTM Thanks! http://codereview.appspot.com/4521064/diff/4009/src/pkg/crypto/openpgp/packet/public_key_test.go File src/pkg/crypto/openpgp/packet/public_key_test.go (right): http://codereview.appspot.com/4521064/diff/4009/src/pkg/crypto/openpgp/packet/public_key_test.go#newcode84 src/pkg/crypto/openpgp/packet/public_key_test.go:84: pk, ok = packet.(*PublicKey) check it for ...

14 years ago (2011-05-13 22:10:37 UTC) #3

agl1

14 years ago (2011-05-14 23:13:55 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=920f1bc872ee ***

crypto/openpgp: change PublicKey.Serialize to include the header.

Signature.Serialize already does this and they should be consistent.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4521064

Expand All Messages | Collapse All Messages