Issue 4521054: code review 4521054: image/bmp: implement a BMP decoder.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4521054: code review 4521054: image/bmp: implement a BMP decoder. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by nigeltao

Modified:
14 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r f39664db2e15 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f39664db2e15 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r f30be40101ea https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -2 lines)			Patch
M	src/pkg/Makefile	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
A	src/pkg/image/bmp/Makefile	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	src/pkg/image/bmp/reader.go	View	1 2 3	1 chunk	+148 lines, -0 lines	0 comments	Download
M	src/pkg/image/decode_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-11 02:54:45 UTC) #1

LGTM wow, that was easy http://codereview.appspot.com/4521054/diff/4005/src/pkg/image/bmp/reader.go File src/pkg/image/bmp/reader.go (right): http://codereview.appspot.com/4521054/diff/4005/src/pkg/image/bmp/reader.go#newcode28 src/pkg/image/bmp/reader.go:28: // decodePaletted reads an ...

14 years ago (2011-05-11 05:18:57 UTC) #2

nigeltao

14 years ago (2011-05-11 18:12:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e02bcde2458d ***

image/bmp: implement a BMP decoder.

R=r
CC=golang-dev
http://codereview.appspot.com/4521054

Expand All Messages | Collapse All Messages