Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(273)

Issue 4518050: code review 4518050: go/ast, go/doc, godoc: consider struct fields and inter... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 7 months ago by gri
Modified:
14 years, 7 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

go/ast, go/doc, godoc: consider struct fields and interface methods when filtering ASTs So far, only top-level names where considered when trimming ASTs using a filter function. For instance, "godoc reflect Implements" didn't show the "Implements" method of the type Interface because the local method name was not considered (on the other hand, "top- level" declared methods associated with types were considered). With this CL, AST filter functions look also at struct fields and interface methods.

Patch Set 1 #

Patch Set 2 : diff -r ae920b31c0d9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ae920b31c0d9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ae920b31c0d9 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ae920b31c0d9 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 6cfeb24159e0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -39 lines) Patch
M src/pkg/go/ast/filter.go View 1 2 5 chunks +48 lines, -11 lines 0 comments Download
M src/pkg/go/doc/doc.go View 1 4 chunks +6 lines, -28 lines 0 comments Download

Messages

Total messages: 4
gri
Hello rsc, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 7 months ago (2011-05-10 00:48:50 UTC) #1
rsc
LGTM
14 years, 7 months ago (2011-05-10 17:58:02 UTC) #2
r
LGTM
14 years, 7 months ago (2011-05-10 17:59:15 UTC) #3
gri
14 years, 7 months ago (2011-05-10 18:10:01 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=de003ba6a506 ***

go/ast, go/doc, godoc: consider struct fields and interface methods when
filtering ASTs

So far, only top-level names where considered when trimming ASTs
using a filter function. For instance, "godoc reflect Implements"
didn't show the "Implements" method of the type Interface because
the local method name was not considered (on the other hand, "top-
level" declared methods associated with types were considered).

With this CL, AST filter functions look also at struct fields
and interface methods.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/4518050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b