Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(468)

Issue 4517136: Vertical spacing, distinguish stretchability/compressibility (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Keith
Modified:
12 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

When stretchability is changed, leave inverse_compression_strength alone %{ The LilyPond Notation Reference says: stretchability – a measure of the dimension’s relative propensity to stretch. [...] Note that the dimension’s propensity to compress cannot be directly set by the user and is equal to (basic-distance - minimum-distance). but in ver2.13.62, 'stretchability affects the ability to compress. The documented behavior would be nice for things like piano pedal lines where we want to disallow stretching, but allow compression to get out of the way of high notes on the next line. %} \paper { ragged-right = ##t paper-height = 80\mm system-system-spacing = #'((minimum-distance . 8) % be close, when needed (basic-distance . 16) (stretchability . 0) (padding . 1) ) } { g'1 \break g, \break g''' }

Patch Set 1 #

Patch Set 2 : have min-dist regtest use min-dist #

Total comments: 11

Patch Set 3 : comments and clarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -36 lines) Patch
M input/regression/page-breaking-min-distance2.ly View 1 1 chunk +1 line, -2 lines 0 comments Download
M lily/align-interface.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M lily/page-layout-problem.cc View 2 chunks +1 line, -9 lines 0 comments Download
M lily/simple-spacer.cc View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M lily/spring.cc View 1 2 2 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 6
joeneeman
http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc File lily/align-interface.cc (left): http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc#oldcode230 lily/align-interface.cc:230: dy = max (dy, Page_layout_problem::get_fixed_spacing (elems[j-1], elems[j], spaceable_count, pure, ...
12 years, 10 months ago (2011-06-04 07:09:05 UTC) #1
Keith
http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc File lily/align-interface.cc (left): http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc#oldcode230 lily/align-interface.cc:230: dy = max (dy, Page_layout_problem::get_fixed_spacing (elems[j-1], elems[j], spaceable_count, pure, ...
12 years, 10 months ago (2011-06-04 10:48:09 UTC) #2
joeneeman
http://codereview.appspot.com/4517136/diff/1001/lily/simple-spacer.cc File lily/simple-spacer.cc (right): http://codereview.appspot.com/4517136/diff/1001/lily/simple-spacer.cc#newcode230 lily/simple-spacer.cc:230: for (++i; i < sorted_springs.size (); i++) On 2011/06/04 ...
12 years, 10 months ago (2011-06-04 17:32:15 UTC) #3
Keith
On 2011/06/04 17:32:15, joeneeman wrote: > > When compressing, unstretchable springs never get put on ...
12 years, 10 months ago (2011-06-05 02:43:03 UTC) #4
joeneeman
ok, lgtm
12 years, 9 months ago (2011-06-10 06:58:49 UTC) #5
Graham Percival (old account)
12 years, 9 months ago (2011-06-16 20:15:16 UTC) #6
countdown over, please push whenever it's convenient, Keith.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b