Issue 4517133: Add EGL context for Windows.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4517133: Add EGL context for Windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by bungeman

Modified:
12 years, 11 months ago

Reviewers:
bsalomon, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Fix whitespace and line length. #

Total comments: 1

Patch Set 3 : Update field names. #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -2 lines)			Patch
M	gyp/utils.gyp	View	1 2	3 chunks	+17 lines, -0 lines	0 comments	Download
M	include/utils/SkEGLContext.h	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
A	src/utils/win/SkEGLContext_Win.cpp	View	1 2	1 chunk	+195 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/4517133/diff/2001/include/utils/SkEGLContext.h File include/utils/SkEGLContext.h (right): http://codereview.appspot.com/4517133/diff/2001/include/utils/SkEGLContext.h#newcode39 include/utils/SkEGLContext.h:39: #elif defined(SK_BUILD_FOR_WIN32) I know I didn't follow this in ...

12 years, 11 months ago (2011-06-02 14:54:37 UTC) #2

bungeman

Changed new field names to use f-prefix convention. We may wish to update existing fields ...

12 years, 11 months ago (2011-06-02 15:26:12 UTC) #3

Expand All Messages | Collapse All Messages