code review 4517116: pkg: spelling tweaks, I-Z

pkg: spelling tweaks, I-Z

also, a few miscellaneous fixes to files outside pkg

[rh, 2011-05-30 02:45:22]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-05-30 02:57:04]

LGTM

wow

http://codereview.appspot.com/4517116/diff/9001/src/pkg/websocket/server.go
File src/pkg/websocket/server.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/websocket/server.go#n...
src/pkg/websocket/server.go:127: // Step 8. let challenge to be concatenation of
part1, part2 and key3.
s/to // while you're here.

[mikio, 2011-05-30 03:08:45]

Mr. Hencke,

On Mon, May 30, 2011 at 11:45 AM,  <robert.hencke@gmail.com> wrote:

> -// IsLinkLinkLocalMulticast returns true if ip is a link-local
> +// IsLinkLocalMulticast returns true if ip is a link-local

> -// IsLinkLinkLocalUnicast returns true if ip is a link-local
> +// IsLinkLocalUnicast returns true if ip is a link-local

> -// and laddr.(type).IP is nil, it assuumes that the user wants to
> +// and laddr.(type).IP is nil, it assumes that the user wants to

I have no words to express my gratitude to you for above chattering
correction. It looks good to me.

[r, 2011-05-30 03:12:16]

http://codereview.appspot.com/4517116/diff/9001/src/pkg/mime/multipart/multip...
File src/pkg/mime/multipart/multipart_test.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/mime/multipart/multip...
src/pkg/mime/multipart/multipart_test.go:318: `,"\n", "\r\n", -1)
this doesn't look right. did gofmt do this?

http://codereview.appspot.com/4517116/diff/9001/src/pkg/net/fd_windows.go
File src/pkg/net/fd_windows.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/net/fd_windows.go#new...
src/pkg/net/fd_windows.go:516: // Not implemented functions.
s/Not /Un/

http://codereview.appspot.com/4517116/diff/9001/src/pkg/net/textproto/reader.go
File src/pkg/net/textproto/reader.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/net/textproto/reader....
src/pkg/net/textproto/reader.go:240: // in text protocols like SMTP.  The data
consists of a sequence
s/like/such as/

http://codereview.appspot.com/4517116/diff/9001/src/pkg/runtime/runtime.h
File src/pkg/runtime/runtime.h (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/runtime/runtime.h#new...
src/pkg/runtime/runtime.h:309: *    you need super-guru privilege
a goru is a gopher guru (just kidding)

[dsymonds, 2011-05-30 03:21:19]

FYI

http://codereview.appspot.com/4517116/diff/9001/src/pkg/mime/multipart/multip...
File src/pkg/mime/multipart/multipart_test.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/mime/multipart/multip...
src/pkg/mime/multipart/multipart_test.go:318: `,"\n", "\r\n", -1)
On 2011/05/30 03:12:17, r wrote:
> this doesn't look right. did gofmt do this?

It's a known bug with gofmt that's already been fixed, but not in a release:
http://code.google.com/p/go/issues/detail?id=1839

[rh, 2011-05-30 07:39:55]

PTAL.
Thank you all for the reviews & suggestions.

On 2011/05/30 03:08:45, mikioh wrote:
> I have no words to express my gratitude to you for above chattering
> correction. It looks good to me.

ありがとうございます、みきおーさん。

http://codereview.appspot.com/4517116/diff/9001/src/pkg/mime/multipart/multip...
File src/pkg/mime/multipart/multipart_test.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/mime/multipart/multip...
src/pkg/mime/multipart/multipart_test.go:318: `,"\n", "\r\n", -1)
On 2011/05/30 03:21:19, dsymonds wrote:
> On 2011/05/30 03:12:17, r wrote:
> > this doesn't look right. did gofmt do this?
> 
> It's a known bug with gofmt that's already been fixed, but not in a release:
> http://code.google.com/p/go/issues/detail?id=1839

Done.
(sorry, was running an old gofmt)

http://codereview.appspot.com/4517116/diff/9001/src/pkg/net/fd_windows.go
File src/pkg/net/fd_windows.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/net/fd_windows.go#new...
src/pkg/net/fd_windows.go:516: // Not implemented functions.
On 2011/05/30 03:12:17, r wrote:
> s/Not /Un/

Done.

http://codereview.appspot.com/4517116/diff/9001/src/pkg/net/textproto/reader.go
File src/pkg/net/textproto/reader.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/net/textproto/reader....
src/pkg/net/textproto/reader.go:240: // in text protocols like SMTP.  The data
consists of a sequence
On 2011/05/30 03:12:17, r wrote:
> s/like/such as/

Done.

http://codereview.appspot.com/4517116/diff/9001/src/pkg/runtime/runtime.h
File src/pkg/runtime/runtime.h (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/runtime/runtime.h#new...
src/pkg/runtime/runtime.h:309: *    you need super-guru privilege
On 2011/05/30 03:12:17, r wrote:
> a goru is a gopher guru (just kidding)

Clarified.  PTAL.

http://codereview.appspot.com/4517116/diff/9001/src/pkg/websocket/server.go
File src/pkg/websocket/server.go (right):

http://codereview.appspot.com/4517116/diff/9001/src/pkg/websocket/server.go#n...
src/pkg/websocket/server.go:127: // Step 8. let challenge to be concatenation of
part1, part2 and key3.
On 2011/05/30 02:57:04, dsymonds wrote:
> s/to // while you're here.

Done.

[r, 2011-05-30 07:49:27]

LGTM

anyone else?

[dsymonds, 2011-05-30 07:58:46]

LGTM

[r, 2011-05-30 08:03:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=74fc11b9e9a8 ***

pkg: spelling tweaks, I-Z

also, a few miscellaneous fixes to files outside pkg

R=golang-dev, dsymonds, mikioh.mikioh, r
CC=golang-dev
http://codereview.appspot.com/4517116

Committer: Rob Pike <r@golang.org>