Issue 4517112: bugfix for: [#26753] PhysicsConstraints ID trouble on 64bit (linux at least).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4517112: bugfix for: [#26753] PhysicsConstraints ID trouble on 64bit (linux at least). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by dfelinto

Modified:
12 years, 11 months ago

Reviewers:
bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

PhysicsId are Long, not ints (see PyObject* KX_GameObject::PyGetPhysicsId() ) There is a reference in the code to use PyCapsule instead of int. I'm not sure about that. This patch at least stops the crashes. Original Blender tracker report: http://projects.blender.org/tracker/index.php?func=detail&aid=26753&group_id=9&atid=306

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -7 lines)			Patch
		source/gameengine/Ketsji/KX_PyConstraintBinding.cpp	View		2 chunks	+36 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2011/05/28 07:10:04, dfelinto wrote:

comitted

Expand All Messages | Collapse All Messages