Issue 4517072: code review 4517072: crypto/x509: support DSA public keys in X.509 certs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4517072: code review 4517072: crypto/x509: support DSA public keys in X.509 certs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by agl1

Modified:
14 years ago

Reviewers:
rsc1, bradfitz

CC:
agl, golang-dev

Visibility:
Public.

Description

crypto/x509: support DSA public keys in X.509 certs.

Patch Set 1 #

Patch Set 2 : diff -r 1f2d6f61ef08 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1f2d6f61ef08 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -15 lines)			Patch
	M	src/pkg/crypto/x509/x509.go	View	1	9 chunks	+63 lines, -15 lines	0 comments	Download
	M	src/pkg/crypto/x509/x509_test.go	View	1	3 chunks	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello agl@chromium.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-16 18:16:46 UTC) #1

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=e5ecc416f2fd *** crypto/x509: support DSA public keys in X.509 certs. R=agl CC=golang-dev ...

14 years ago (2011-05-16 18:17:19 UTC) #2

agl1

On Mon, May 16, 2011 at 11:18 AM, Russ Cox <rsc@google.com> wrote: > Was this ...

14 years ago (2011-05-16 18:23:26 UTC) #4

bradfitz

14 years ago (2011-05-16 18:31:20 UTC) #5

On Mon, May 16, 2011 at 11:23 AM, Adam Langley <agl@golang.org> wrote:

> On Mon, May 16, 2011 at 11:18 AM, Russ Cox <rsc@google.com> wrote:
> > Was this jonallie's CL?  Did hg clpatch fail?
>
> Yes, it needed merging (I suspect that it was based on release rather
> than HEAD). Setting "Author:" didn't appear to work.
>

Did you set it all on one line?

Author: foo

instead of:

Author:
            foo


... that bit me recently.

Expand All Messages | Collapse All Messages