Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(560)

Issue 4516055: code review 4516055: 8l: emit resources (.rsrc) in Windows PE. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 7 months ago by vcc
Modified:
14 years, 7 months ago
Reviewers:
CC:
brainman, rsc, golang-dev, vcc
Visibility:
Public.

Description

8l: emit resources (.rsrc) in Windows PE.

Patch Set 1 #

Patch Set 2 : code review 4516055: 8l: emit resources (.rsrc) in Windows PE. #

Patch Set 3 : code review 4516055: 8l: emit resources (.rsrc) in Windows PE. #

Total comments: 10

Patch Set 4 : code review 4516055: 8l: emit resources (.rsrc) in Windows PE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M src/cmd/ld/ldpe.c View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M src/cmd/ld/pe.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/ld/pe.c View 1 2 3 3 chunks +47 lines, -1 line 0 comments Download

Messages

Total messages: 7
vcc
Hello brainman (cc: golang-dev@googlegroups.com, vcc), I'd like you to review this change.
14 years, 7 months ago (2011-05-15 06:59:22 UTC) #1
rsc
http://codereview.appspot.com/4516055/diff/5001/src/cmd/ld/ldpe.c File src/cmd/ld/ldpe.c (right): http://codereview.appspot.com/4516055/diff/5001/src/cmd/ld/ldpe.c#newcode226 src/cmd/ld/ldpe.c:226: setpersrc(sect->sh.SizeOfRawData, sect->base, sect->sym); Since sect->sym->p == sect->base and sect->sym->size ...
14 years, 7 months ago (2011-05-16 20:48:26 UTC) #2
brainman
Welcome back and thank you. Alex http://codereview.appspot.com/4516055/diff/5001/src/cmd/ld/pe.c File src/cmd/ld/pe.c (right): http://codereview.appspot.com/4516055/diff/5001/src/cmd/ld/pe.c#newcode484 src/cmd/ld/pe.c:484: IMAGE_SCN_MEM_WRITE | IMAGE_SCN_CNT_INITIALIZED_DATA; ...
14 years, 7 months ago (2011-05-17 00:33:19 UTC) #3
vcc
PTAL http://codereview.appspot.com/4516055/diff/5001/src/cmd/ld/ldpe.c File src/cmd/ld/ldpe.c (right): http://codereview.appspot.com/4516055/diff/5001/src/cmd/ld/ldpe.c#newcode226 src/cmd/ld/ldpe.c:226: setpersrc(sect->sh.SizeOfRawData, sect->base, sect->sym); On 2011/05/16 20:48:26, rsc wrote: ...
14 years, 7 months ago (2011-05-17 08:20:30 UTC) #4
brainman
LGTM
14 years, 7 months ago (2011-05-21 13:29:46 UTC) #5
rsc
LGTM
14 years, 7 months ago (2011-05-25 11:51:35 UTC) #6
rsc
14 years, 7 months ago (2011-05-25 11:53:03 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=99a520c00dcf ***

8l: emit resources (.rsrc) in Windows PE.

R=alex.brainman, rsc
CC=golang-dev, vcc.163
http://codereview.appspot.com/4516055

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b