Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(723)

Issue 4516052: Camera Lock View v3

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by ideasman42
Modified:
12 years, 11 months ago
Reviewers:
jesterKing
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This makes view3ds camea follow rotate/pan/zoom/dolly operators. Now addes support for almost all view operators... - auto-depth preference now works - smooth view navigation supports too. - view selected, all & numpad operator work too. Unless some other problems come up I consider this patch basically finished & ready for review.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -20 lines) Patch
release/scripts/startup/bl_ui/space_view3d.py View 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/editors/include/ED_view3d.h View 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/editors/space_view3d/view3d_edit.c View 26 chunks +83 lines, -19 lines 0 comments Download
source/blender/editors/space_view3d/view3d_view.c View 3 chunks +9 lines, -1 line 3 comments Download
source/blender/makesdna/DNA_view3d_types.h View 1 chunk +1 line, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_space.c View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
ideasman42
12 years, 11 months ago (2011-05-14 07:56:29 UTC) #1
jesterKing
On 2011/05/14 07:56:29, ideasman42 wrote: Hi, looks like you have specified a wrong base url: ...
12 years, 11 months ago (2011-05-14 08:07:06 UTC) #2
jesterKing
http://codereview.appspot.com/4516052/diff/1/source/blender/editors/space_view3d/view3d_view.c File source/blender/editors/space_view3d/view3d_view.c (right): http://codereview.appspot.com/4516052/diff/1/source/blender/editors/space_view3d/view3d_view.c#newcode169 source/blender/editors/space_view3d/view3d_view.c:169: Wouldn't it make sense to set camera here too?
12 years, 11 months ago (2011-05-14 14:00:56 UTC) #3
ideasman42
12 years, 11 months ago (2011-05-14 16:49:05 UTC) #4
added comment

http://codereview.appspot.com/4516052/diff/1/source/blender/editors/space_vie...
File source/blender/editors/space_view3d/view3d_view.c (right):

http://codereview.appspot.com/4516052/diff/1/source/blender/editors/space_vie...
source/blender/editors/space_view3d/view3d_view.c:169: 
On 2011/05/14 14:00:56, jesterKing wrote:
> Wouldn't it make sense to set camera here too?

No, what happens in this case is smoothview is not dealing with change cameras,
Its just interpolating ofs/viewquat/dist.

In the case where camera locking is used (checked in
ED_view3d_camera_lock_init), we want the camera/view to stay unchanged - and
just copy from the rv3d to the camera object on each smoothview update,

I can give more comprehensive comment about this :)

http://codereview.appspot.com/4516052/diff/1/source/blender/editors/space_vie...
source/blender/editors/space_view3d/view3d_view.c:169: 
On 2011/05/14 14:00:56, jesterKing wrote:
> Wouldn't it make sense to set camera here too?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b