Issue 4515181: fix gyp-generated xcode project files for SampleApp and other targets

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515181: fix gyp-generated xcode project files for SampleApp and other targets (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by epoger

Modified:
12 years, 11 months ago

Reviewers:
bungeman

CC:
bsalomon, skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

With this change, I can successfully build SampleApp and test targets from XCode on Mac, using the GYP-generated xcode projects!

Patch Set 2 : whitespace fixes #

Patch Set 3 : more whitespace fixes #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
M	gyp/core.gyp	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	gyp/utils.gyp	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	gyp/views.gyp	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

Aside from white space, LGTM. http://codereview.appspot.com/4515181/diff/1/gyp/utils.gyp File gyp/utils.gyp (right): http://codereview.appspot.com/4515181/diff/1/gyp/utils.gyp#newcode95 gyp/utils.gyp:95: [ 'OS == "mac"', ...

12 years, 11 months ago (2011-06-02 19:42:03 UTC) #2

Fixed whitespace and committed as r1482

Expand All Messages | Collapse All Messages