Issue 4515159: code review 4515159: gob: fix documentation on Decoder.Decode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515159: code review 4515159: gob: fix documentation on Decoder.Decode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by dsymonds

Modified:
13 years, 11 months ago

Reviewers:

CC:
r, adg, golang-dev

Visibility:
Public.

Description

gob: fix documentation on Decoder.Decode.

Patch Set 2 : diff -r 7e539bf111cd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7e539bf111cd https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r e3d8afba9765 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/gob/decoder.go	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-05-30 00:27:19 UTC) #1

LGTM http://codereview.appspot.com/4515159/diff/5001/src/pkg/gob/decoder.go File src/pkg/gob/decoder.go (right): http://codereview.appspot.com/4515159/diff/5001/src/pkg/gob/decoder.go#newcode159 src/pkg/gob/decoder.go:159: // data item received. re-align lines.

13 years, 11 months ago (2011-05-30 00:46:26 UTC) #3

dsymonds

http://codereview.appspot.com/4515159/diff/5001/src/pkg/gob/decoder.go File src/pkg/gob/decoder.go (right): http://codereview.appspot.com/4515159/diff/5001/src/pkg/gob/decoder.go#newcode159 src/pkg/gob/decoder.go:159: // data item received. On 2011/05/30 00:46:26, r wrote: ...

13 years, 11 months ago (2011-05-30 00:47:36 UTC) #4

dsymonds

13 years, 11 months ago (2011-05-30 00:48:16 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=a9dc537743b7 ***

gob: fix documentation on Decoder.Decode.

R=r, adg
CC=golang-dev
http://codereview.appspot.com/4515159

Expand All Messages | Collapse All Messages