code review 4515073: image/tiff: Reject images with SampleFormat != 1.

image/tiff: Reject images with SampleFormat != 1.

The TIFF spec says that a baseline TIFF reader must gracefully terminate
when the image has a SampleFormat tag which it does not support.
For baseline compatibility, only SampleFormat=1 (the default) is needed.
Images with other sample formats (e.g. floating-point color values)
are very rare in practice.

[bsiegert, 2011-05-12 20:26:11]

Hello nigeltao (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2011-05-12 20:41:14]

LGTM.

[rsc, 2011-05-13 02:34:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=f131fe9b1b9b ***

image/tiff: Reject images with SampleFormat != 1.

The TIFF spec says that a baseline TIFF reader must gracefully terminate
when the image has a SampleFormat tag which it does not support.
For baseline compatibility, only SampleFormat=1 (the default) is needed.
Images with other sample formats (e.g. floating-point color values)
are very rare in practice.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/4515073

Committer: Russ Cox <rsc@golang.org>

[rsc, 2011-05-13 02:36:24]

I still don't know what's wrong with your client, Nigel.
If you have time to fiddle with the Python a little to
investigate that would be great.  I tried and it worked for me.

Russ

[gri, 2011-05-13 02:53:10]

I am seing the same (?) problem at home. I tried a clpatch and got:

hg clpatch 4528060
local repository is out of date; sync to get dd5166932c9a

I've seen yesterday evening for the first time. Until then, my client
at home behaved fine.

Not sure this helps.
- Robert

On Thu, May 12, 2011 at 7:36 PM, Russ Cox <rsc@golang.org> wrote:
> I still don't know what's wrong with your client, Nigel.
> If you have time to fiddle with the Python a little to
> investigate that would be great.  I tried and it worked for me.
>
> Russ
>

[rsc, 2011-05-13 02:59:48]

Can you please try this?

$ python
Python 2.6.1 (r261:67515, Jun 24 2010, 21:47:49)
[GCC 4.2.1 (Apple Inc. build 5646)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from mercurial import ui, hg
>>> repo = hg.repository(ui.ui(), '.')
>>> "dd5166932c9a" in repo
True
>>> repo["dd5166932c9a"]
<changectx dd5166932c9a>
>>>