code review 4485045: crypto/x509/crl: add package

crypto/x509/crl: add package

crl parses CRLs and exposes their details. In the future, Verify
should be able to use this for revocation checking.

[agl1, 2011-05-05 17:51:07]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-05-07 22:02:56]

http://codereview.appspot.com/4485045/diff/2013/src/pkg/crypto/x509/crl/crl.go
File src/pkg/crypto/x509/crl/crl.go (right):

http://codereview.appspot.com/4485045/diff/2013/src/pkg/crypto/x509/crl/crl.g...
src/pkg/crypto/x509/crl/crl.go:27: func (certList *CertificateList)
HasExpired(currentTime int64) bool {
until Go figures out its time type situation, let's be explicit in the variable
name that this is NOT nanoseconds here (which is more standard) and is instead
seconds.

currentTimeSeconds?

But is this only here for testing?  Will this be odd for caller code?

Could also do something like you did elsewhere in crypto, with an optional clock
(where nil meant time.Seconds()), but not sure if that'd be awkward inside
CertificateList or not.

either way.

[agl1, 2011-05-11 14:39:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=5581570506e5 ***

crypto/x509/crl: add package

crl parses CRLs and exposes their details. In the future, Verify
should be able to use this for revocation checking.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4485045

http://codereview.appspot.com/4485045/diff/2013/src/pkg/crypto/x509/crl/crl.go
File src/pkg/crypto/x509/crl/crl.go (right):

http://codereview.appspot.com/4485045/diff/2013/src/pkg/crypto/x509/crl/crl.g...
src/pkg/crypto/x509/crl/crl.go:27: func (certList *CertificateList)
HasExpired(currentTime int64) bool {
On 2011/05/07 22:02:57, bradfitz wrote:
> until Go figures out its time type situation, let's be explicit in the
variable
> name that this is NOT nanoseconds here (which is more standard) and is instead
> seconds.

Done.

> But is this only here for testing?  Will this be odd for caller code?

It's used by caller code, but I'm likely to be writing all the calling code to.
When we get a time type sorted out I can change it.