code review 4485044: crypto/x509: export raw SubjectPublicKeyInfo.

crypto/x509: export raw SubjectPublicKeyInfo.

The SPKI will probably be used for identifying public keys in future
HSTS specs.

[agl1, 2011-05-05 16:30:18]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-05-05 16:37:48]

LGTM

On Thu, May 5, 2011 at 9:30 AM, <agl@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> crypto/x509: export raw SubjectPublicKeyInfo.
>
> The SPKI will probably be used for identifying public keys in future
> HSTS specs.
>
> Please review this at http://codereview.appspot.com/4485044/
>
> Affected files:
>  M src/pkg/crypto/x509/x509.go
>
>
> Index: src/pkg/crypto/x509/x509.go
> ===================================================================
> --- a/src/pkg/crypto/x509/x509.go
> +++ b/src/pkg/crypto/x509/x509.go
> @@ -186,6 +186,7 @@
>  }
>
>  type publicKeyInfo struct {
> +       Raw       asn1.RawContent
>        Algorithm algorithmIdentifier
>        PublicKey asn1.BitString
>  }
> @@ -402,8 +403,10 @@
>
>  // A Certificate represents an X.509 certificate.
>  type Certificate struct {
> -       Raw                []byte // Complete ASN.1 DER content
> (certificate, signature algorithm and signature).
> -       RawTBSCertificate  []byte // Certificate part of raw ASN.1 DER
> content.
> +       Raw                     []byte // Complete ASN.1 DER content
> (certificate, signature algorithm and signature).
> +       RawTBSCertificate       []byte // Certificate part of raw ASN.1 DER
> content.
> +       RawSubjectPublicKeyInfo []byte // DER encoded SubjectPublicKeyInfo.
> +
>        Signature          []byte
>        SignatureAlgorithm SignatureAlgorithm
>
> @@ -567,6 +570,7 @@
>        out := new(Certificate)
>        out.Raw = in.Raw
>        out.RawTBSCertificate = in.TBSCertificate.Raw
> +       out.RawSubjectPublicKeyInfo = in.TBSCertificate.PublicKey.Raw
>
>        out.Signature = in.SignatureValue.RightAlign()
>        out.SignatureAlgorithm =
> @@ -983,7 +987,7 @@
>                Issuer:             parent.Subject.toRDNSequence(),
>                Validity:           validity{template.NotBefore,
> template.NotAfter},
>                Subject:            template.Subject.toRDNSequence(),
> -               PublicKey:
>  publicKeyInfo{algorithmIdentifier{oidRSA}, encodedPublicKey},
> +               PublicKey:          publicKeyInfo{nil,
> algorithmIdentifier{oidRSA}, encodedPublicKey},
>                Extensions:         extensions,
>        }
>
>
>
>

[agl1, 2011-05-05 17:36:51]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[agl1, 2011-05-05 17:37:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=7ca2030ada05 ***

crypto/x509: export raw SubjectPublicKeyInfo.

The SPKI will probably be used for identifying public keys in future
HSTS specs.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4485044