Issue 4479047: code review 4479047: syscall: fix bug in mksyscall_windows.pl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4479047: code review 4479047: syscall: fix bug in mksyscall_windows.pl (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by brainman

Modified:
14 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

syscall: fix bug in mksyscall_windows.pl This change fixes generation of "shadow" variables for bool parameters. Before the change, it was naming all bool variables with the same name of _p0. Now it calls them _p0, _p1, ... So the code could compile.

Patch Set 1 #

Patch Set 2 : diff -r 29f6e2e230a3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 29f6e2e230a3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r bebd6359804f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r e70580858a87 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/syscall/mksyscall_windows.pl	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-06 06:52:29 UTC) #1

brainman

On 2011/05/06 07:04:37, r wrote: > what's the bug? "fix bug" is not a helpful ...

14 years ago (2011-05-06 07:09:04 UTC) #3

brainman

Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-05-06 07:31:36 UTC) #4

brainman

14 years ago (2011-05-08 06:32:05 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=16aa8473ffb4 ***

syscall: fix bug in mksyscall_windows.pl

This change fixes generation of "shadow" variables for bool parameters.
Before the change, it was naming all bool variables with the same name of _p0.
Now it calls them _p0, _p1, ... So the code could compile.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4479047

Expand All Messages | Collapse All Messages