Issue 4476049: code review 4476049: cgo: put CFLAGS before filename argument

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4476049: code review 4476049: cgo: put CFLAGS before filename argument (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by rog

Modified:
13 years, 9 months ago

Reviewers:

CC:
iant, rsc, golang-dev

Visibility:
Public.

Description

cgo: put CFLAGS before filename argument This means that the -x flag can work, which could enable support for other languages (e.g. objective-C).

Patch Set 2 : diff -r 502384dd99e8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 502384dd99e8 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 502384dd99e8 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	src/cmd/cgo/gcc.go	View	1 2 3	4 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rog

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-06 10:03:02 UTC) #1

iant

http://codereview.appspot.com/4476049/diff/3/src/cmd/cgo/gcc.go File src/cmd/cgo/gcc.go (right): http://codereview.appspot.com/4476049/diff/3/src/cmd/cgo/gcc.go#newcode619 src/cmd/cgo/gcc.go:619: c = append(c, "-") Copy the comment too, please ...

14 years ago (2011-05-06 15:33:53 UTC) #2

rog

14 years ago (2011-05-06 15:48:04 UTC) #3

rsc

LGTM Strong emphasis on "could". The only language we promise will work is C. :-)

14 years ago (2011-05-06 20:08:30 UTC) #5

iant

14 years ago (2011-05-06 20:36:04 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=21edcf23b7a8 ***

cgo: put CFLAGS before filename argument
This means that the -x flag can work, which could enable
support for other languages (e.g. objective-C).

R=iant, rsc
CC=golang-dev
http://codereview.appspot.com/4476049

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages