code review 4466041: net: disable dnsmsg_test on windows

net: disable dnsmsg_test on windows

[brainman, 2011-05-04 02:52:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitzgoog, 2011-05-04 03:01:49]

LGTM

(phone), brad
On May 3, 2011 7:52 PM, <alex.brainman@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: disable dnsmsg_test on windows
>
> Please review this at http://codereview.appspot.com/4466041/
>
> Affected files:
> M src/pkg/net/dnsmsg_test.go
> M src/pkg/net/resolv_windows.go
>
>
> Index: src/pkg/net/dnsmsg_test.go
> ===================================================================
> --- a/src/pkg/net/dnsmsg_test.go
> +++ b/src/pkg/net/dnsmsg_test.go
> @@ -6,10 +6,14 @@
>
> import (
> "encoding/hex"
> + "runtime"
> "testing"
> )
>
> func TestDNSParseSRVReply(t *testing.T) {
> + if runtime.GOOS == "windows" {
> + return
> + }
> data, err := hex.DecodeString(dnsSRVReply)
> if err != nil {
> t.Fatal(err)
> @@ -41,6 +45,9 @@
> }
>
> func TestDNSParseCorruptSRVReply(t *testing.T) {
> + if runtime.GOOS == "windows" {
> + return
> + }
> data, err := hex.DecodeString(dnsSRVCorruptReply)
> if err != nil {
> t.Fatal(err)
> Index: src/pkg/net/resolv_windows.go
> ===================================================================
> --- a/src/pkg/net/resolv_windows.go
> +++ b/src/pkg/net/resolv_windows.go
> @@ -113,6 +113,10 @@
> panic("unimplemented")
> }
>
> +func answer(name, server string, dns *dnsMsg, qtype uint16) (cname
string,
> addrs []dnsRR, err os.Error) {
> + panic("unimplemented")
> +}
> +
> // DNSError represents a DNS lookup error.
> type DNSError struct {
> Error string // description of the error
>
>

[brainman, 2011-05-04 03:08:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=0c0fa41bc26c ***

net: disable dnsmsg_test on windows

R=golang-dev, bradfitzwork
CC=golang-dev
http://codereview.appspot.com/4466041