code review 4462046: crypto/tls: export the verified chains.

crypto/tls: export the verified chains.

The verified chains are the chains that were actually verified.

[agl1, 2011-05-05 16:28:14]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-05-05 16:35:26]

LGTM

On Thu, May 5, 2011 at 9:28 AM, <agl@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> crypto/tls: export the verified chains.
>
> The verified chains are the chains that were actually verified.
>
> Please review this at http://codereview.appspot.com/4462046/
>
> Affected files:
>  M src/pkg/crypto/tls/common.go
>  M src/pkg/crypto/tls/conn.go
>
>
> Index: src/pkg/crypto/tls/common.go
> ===================================================================
> --- a/src/pkg/crypto/tls/common.go
> +++ b/src/pkg/crypto/tls/common.go
> @@ -100,6 +100,8 @@
>
>        // the certificate chain that was presented by the other side
>        PeerCertificates []*x509.Certificate
> +       // the verified certificate chains built from PeerCertificates.
> +       VerifiedChains [][]*x509.Certificate
>  }
>
>  // A Config structure is used to configure a TLS client or server. After
> one
> Index: src/pkg/crypto/tls/conn.go
> ===================================================================
> --- a/src/pkg/crypto/tls/conn.go
> +++ b/src/pkg/crypto/tls/conn.go
> @@ -768,6 +768,7 @@
>                state.NegotiatedProtocolIsMutual = !c.clientProtocolFallback
>                state.CipherSuite = c.cipherSuite
>                state.PeerCertificates = c.peerCertificates
> +               state.VerifiedChains = c.verifiedChains
>        }
>
>        return state
>
>
>

[agl1, 2011-05-05 17:44:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=62e4846d10de ***

crypto/tls: export the verified chains.

The verified chains are the chains that were actually verified.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4462046