code review 4462043: go spec: newlines cannot be used inside a char or "" st...

go spec: newlines cannot be used inside a char or "" string literal

[gri, 2011-05-04 22:14:22]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-05-04 23:14:37]

PS: This simply fixes a bug in the current syntax. We may need to
reconsider this with respect to issue 680 (
http://code.google.com/p/go/issues/detail?id=680 ).
- gri

On Wed, May 4, 2011 at 3:14 PM,  <gri@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> go spec: newlines cannot be used inside a char or "" string literal
>
> Please review this at http://codereview.appspot.com/4462043/
>
> Affected files:
>  M doc/go_spec.html
>
>
> Index: doc/go_spec.html
> ===================================================================
> --- a/doc/go_spec.html
> +++ b/doc/go_spec.html
> @@ -1,5 +1,5 @@
>  <!-- title The Go Programming Language Specification -->
> -<!-- subtitle Version of May 2, 2011 -->
> +<!-- subtitle Version of May 4, 2011 -->
>
>  <!--
>  TODO
> @@ -102,7 +102,8 @@
>  The following terms are used to denote specific Unicode character classes:
>  </p>
>  <pre class="ebnf">
> -unicode_char   = /* an arbitrary Unicode code point */ .
> +newline        = /* the Unicode code point U+000A */ .
> +unicode_char   = /* an arbitrary Unicode code point except newline */ .
>  unicode_letter = /* a Unicode code point classified as "Letter" */ .
>  unicode_digit  = /* a Unicode code point classified as "Decimal Digit" */ .
>  </pre>
> @@ -471,7 +472,7 @@
>
>  <pre class="ebnf">
>  string_lit             = raw_string_lit | interpreted_string_lit .
> -raw_string_lit         = "`" { unicode_char } "`" .
> +raw_string_lit         = "`" { unicode_char | newline } "`" .
>  interpreted_string_lit = `"` { unicode_value | byte_value } `"` .
>  </pre>
>
>
>
>

[r, 2011-05-05 03:16:08]

LGTM

[gri, 2011-05-05 16:03:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=fcd86d58ea1e ***

go spec: newlines cannot be used inside a char or "" string literal

R=r
CC=golang-dev
http://codereview.appspot.com/4462043