code review 4457049: doc: release.r57

doc: release.r57

[rsc, 2011-05-03 17:21:31]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2011-05-03 17:29:18]

http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html
File doc/devel/release.html (right):

http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html#newcode14
doc/devel/release.html:14: hg update release.r<i>NN</i>
is there a flag? or is it just "update release.rNN"? it's not clear to me what
the -r flag is for.

http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html#newcode83
doc/devel/release.html:83: and redirects followed.  These abstractions make it
easy to implement
s/redirects/redirections/?

http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html#newcod...
doc/devel/release.html:105: resolve names the same way and also avoids tripping
the OS X
"tripping" is an odd word for a firewall.
how about just "avoids the OS X application-level firewall"?

http://codereview.appspot.com/4457049/diff/6001/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/4457049/diff/6001/doc/devel/weekly.html#newcode6
doc/devel/weekly.html:6: <p>The weekly snapshots change quickly and may not be
stable.
the snapshots don't change, they get added to.
how about

Weekly snapshots occur often and may not be stable.

[rsc, 2011-05-03 17:32:10]

>
http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html#newcode14
> doc/devel/release.html:14: hg update release.r<i>NN</i>
> is there a flag? or is it just "update release.rNN"? it's not clear to
> me what the -r flag is for.

The -r flag is a no-op.  It exists because all the other
commands put a -r before that kind of argument.
By trying to be helpful they created confusion.

>
http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html#newcode83
> doc/devel/release.html:83: and redirects followed.  These abstractions
> make it easy to implement
> s/redirects/redirections/?

Done.

>
http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html#newcod...
> doc/devel/release.html:105: resolve names the same way and also avoids
> tripping the OS X
> "tripping" is an odd word for a firewall.
> how about just "avoids the OS X application-level firewall"?

Done.

> http://codereview.appspot.com/4457049/diff/6001/doc/devel/weekly.html
> File doc/devel/weekly.html (right):
>
> http://codereview.appspot.com/4457049/diff/6001/doc/devel/weekly.html#newcode6
> doc/devel/weekly.html:6: <p>The weekly snapshots change quickly and may
> not be stable.
> the snapshots don't change, they get added to.
> how about
>
> Weekly snapshots occur often and may not be stable.

Done.

[r, 2011-05-03 17:33:32]

LGTM but wait for others.

[adg, 2011-05-03 17:40:31]

http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html
File doc/devel/release.html (right):

http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html#newcode23
doc/devel/release.html:23: This section highlights the most significant changes
in this release.
This boilerplate will become noise when it is repeated for every release. Why
not fold this and the next two sentences (some of which already appear there)
into the intro section?

http://codereview.appspot.com/4457049/diff/10001/doc/all.css
File doc/all.css (left):

http://codereview.appspot.com/4457049/diff/10001/doc/all.css#oldcode143
doc/all.css:143: background: #E2E7F0;
I just spent a few moments wondering why the headings were so indistinct. Leave
this, please.

[rsc, 2011-05-03 17:43:58]

> http://codereview.appspot.com/4457049/diff/10001/doc/all.css#oldcode143
> doc/all.css:143: background: #E2E7F0;
> I just spent a few moments wondering why the headings were so
> indistinct. Leave this, please.

The weekly looks awful with this.
I changed the h3 to h2 (because the
h2 was redundant with the h1) and
then there were colored boxes
everywhere (h2 right next to pre).

Let's figure something else out.

[adg, 2011-05-03 17:51:13]

LGTM

[rsc, 2011-05-03 17:53:47]

anyone else to wait for?

[r2, 2011-05-03 17:54:50]

go for it

[rsc, 2011-05-03 17:56:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=d222384d1bad ***

doc: release.r57

R=golang-dev, r, adg, r2
CC=golang-dev
http://codereview.appspot.com/4457049

[rsc, 2011-05-03 22:03:51]

>
http://codereview.appspot.com/4457049/diff/6001/doc/devel/release.html#newcode23
> doc/devel/release.html:23: This section highlights the most significant
> changes in this release.
> This boilerplate will become noise when it is repeated for every
> release. Why not fold this and the next two sentences (some of which
> already appear there) into the intro section?

I read but forgot this comment until just now.
I did not move the text.  It has hyperlinks that
will be different from release to release.