Issue 4444080: code review 4444080: undo CL 4428057 / 19e540fc7d7d

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4444080: code review 4444080: undo CL 4428057 / 19e540fc7d7d (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by gri

Modified:
13 years ago

Reviewers:

CC:
golang-dev, rsc1

Visibility:
Public.

Description

undo CL 4428057 / 19e540fc7d7d The CL introduces inconsistencies with respect to the use of parentheses/grouping of receive operations. ««« original CL description spec: narrow syntax for expression and select statements This is not a language change, it simply expresses the accepted cases explicitly in the respective productions. R=rsc, r, iant CC=golang-dev http://codereview.appspot.com/4428057 »»»

Patch Set 1 #

Patch Set 2 : diff -r 304d7d2b1d6c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 304d7d2b1d6c https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	doc/go_spec.html	View	1	4 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2011-04-29 19:14:15 UTC) #1

gri

13 years ago (2011-04-29 19:20:34 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a6464cb92a7a ***

undo CL 4428057 / 19e540fc7d7d

The CL introduces inconsistencies with respect to
the use of parentheses/grouping of receive operations.

««« original CL description
spec: narrow syntax for expression and select statements

This is not a language change, it simply expresses the
accepted cases explicitly in the respective productions.

R=rsc, r, iant
CC=golang-dev
http://codereview.appspot.com/4428057
»»»

R=golang-dev, rsc1
CC=golang-dev
http://codereview.appspot.com/4444080

Expand All Messages | Collapse All Messages