Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1574)

Issue 4444076: [google] LIPO regression tests and bug fixes

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 12 months ago by davidxl
Modified:
13 years, 11 months ago
Reviewers:
xur, hubicka
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/gcc/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1470 lines, -28 lines) Patch
M cgraphunit.c View 1 chunk +0 lines, -5 lines 0 comments Download
M dwarf2out.c View 3 chunks +5 lines, -5 lines 0 comments Download
M final.c View 2 chunks +2 lines, -2 lines 0 comments Download
M gcov-dump.c View 1 chunk +4 lines, -3 lines 0 comments Download
M l-ipo.c View 4 chunks +14 lines, -3 lines 0 comments Download
A testsuite/g++.dg/tree-prof/lipo/indir-call-prof.C View 1 chunk +39 lines, -0 lines 0 comments Download
A testsuite/g++.dg/tree-prof/lipo/indir-call-prof-2.C View 1 chunk +35 lines, -0 lines 0 comments Download
A testsuite/g++.dg/tree-prof/lipo/inline_mismatch_args.C View 1 chunk +36 lines, -0 lines 0 comments Download
A testsuite/g++.dg/tree-prof/lipo/lipo.exp View 1 chunk +54 lines, -0 lines 0 comments Download
A testsuite/g++.dg/tree-prof/lipo/partition1.C View 1 chunk +54 lines, -0 lines 0 comments Download
A testsuite/g++.dg/tree-prof/lipo/partition2.C View 1 chunk +16 lines, -0 lines 0 comments Download
A testsuite/g++.dg/tree-prof/lipo/partition3.C View 1 chunk +18 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/bb-reorg.c View 1 chunk +39 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/gdb_cmd View 1 chunk +5 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/ic-misattribution-1.c View 1 chunk +19 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/ic-misattribution-1a.c View 1 chunk +22 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/indir-call-prof.c View 1 chunk +43 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/indir-call-prof.c.040i.tree_profile_ipa View 1 chunk +306 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/indir-call-prof.c.145t.optimized View 1 chunk +229 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/indir-call-prof.gcda.imports View 0 chunks +-1 lines, --1 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/inliner-1.c View 1 chunk +42 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/lipo.exp View 1 chunk +54 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/pr34999.c View 1 chunk +45 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/pr45354.c View 1 chunk +43 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/pr47187.c View 1 chunk +23 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/stringop-1.c View 1 chunk +22 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/stringop-2.c View 1 chunk +20 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/tracer-1.c View 1 chunk +18 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/update-cunroll-2.c View 1 chunk +21 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/update-loopch.c View 1 chunk +21 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/update-tailcall.c View 1 chunk +20 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/val-prof-1.c View 1 chunk +22 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/val-prof-2.c View 1 chunk +32 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/val-prof-3.c View 1 chunk +32 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/val-prof-4.c View 1 chunk +32 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/val-prof-5.c View 1 chunk +17 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/val-prof-6.c View 1 chunk +20 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/val-prof-7.c View 1 chunk +26 lines, -0 lines 0 comments Download
A testsuite/gcc.dg/tree-prof/lipo/wcoverage-mismatch.c View 1 chunk +20 lines, -0 lines 0 comments Download
M tree-profile.c View 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 10
davidxl
This patch added regression tests for LIPO in google/main and fixes a couple of bugs ...
13 years, 12 months ago (2011-04-28 23:18:34 UTC) #1
xur
LGTM. -Rong On Thu, Apr 28, 2011 at 4:18 PM, David Li <davidxl@google.com> wrote: > ...
13 years, 12 months ago (2011-04-28 23:32:37 UTC) #2
hubicka_ucw.cz
Hi, It seems that majority of testcases are independent of lipo. We could probably enjoy ...
13 years, 12 months ago (2011-04-29 23:16:24 UTC) #3
davidxl
On Fri, Apr 29, 2011 at 4:16 PM, Jan Hubicka <hubicka@ucw.cz> wrote: > Hi, > ...
13 years, 12 months ago (2011-04-29 23:28:35 UTC) #4
hubicka_ucw.cz
> On Fri, Apr 29, 2011 at 4:16 PM, Jan Hubicka <hubicka@ucw.cz> wrote: > > ...
13 years, 11 months ago (2011-04-30 09:21:26 UTC) #5
davidxl
On Sat, Apr 30, 2011 at 2:21 AM, Jan Hubicka <hubicka@ucw.cz> wrote: >> On Fri, ...
13 years, 11 months ago (2011-04-30 16:37:59 UTC) #6
hubicka_ucw.cz
> On Sat, Apr 30, 2011 at 2:21 AM, Jan Hubicka <hubicka@ucw.cz> wrote: > >> ...
13 years, 11 months ago (2011-04-30 17:07:17 UTC) #7
davidxl
On Sat, Apr 30, 2011 at 10:07 AM, Jan Hubicka <hubicka@ucw.cz> wrote: >> On Sat, ...
13 years, 11 months ago (2011-04-30 22:42:55 UTC) #8
hubicka_ucw.cz
> How about change "tree_profile_ipa" to "tree-profile" and > "ipa-profile" to "profile-estimate" -- basically drop ...
13 years, 11 months ago (2011-05-01 14:16:07 UTC) #9
davidxl
13 years, 11 months ago (2011-05-01 17:03:44 UTC) #10
On Sun, May 1, 2011 at 7:16 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> How about  change "tree_profile_ipa" to "tree-profile" and
>> "ipa-profile" to "profile-estimate" -- basically drop the ipa in the
>> name. There are also many other passes using '_' though. Can tree
>> level pass_profile's name also be changed to 'profile-estimate'? Their
>> dump names won't collide.
>
> profile-estimate for tree and IPA passes seems fine.  I would drop tree from
> tree-profile pass name, too.  We no longer have RTL profiling.

I agree.

Thanks,

David

>
> Honza
>>
>> Thanks,
>>
>> David
>>
>>
>> > Honza
>> >>
>> >> David
>> >>
>> >> >
>> >> > Honza
>> >> >
>> >
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b