LGTM. It wasn't necessary to remove \chordGlissando from the text of the non-english docs, and ...
12 years, 12 months ago
(2011-05-01 20:15:22 UTC)
#2
LGTM.
It wasn't necessary to remove \chordGlissando from the text of the non-english
docs, and it may even have been best not to do so.
We need to keep compiling working, so if these docs had a snippet containing
\chordGlissando, we would have needed to change that. But since the snippet was
included as a file, it was sufficient to change the file.
Please go ahead and push.
Thanks,
Carl
On May 1, 2011, at 1:15 PM, Carl.D.Sorensen@gmail.com wrote: > LGTM. > > It wasn't ...
12 years, 12 months ago
(2011-05-01 20:32:24 UTC)
#3
On May 1, 2011, at 1:15 PM, Carl.D.Sorensen@gmail.com wrote:
> LGTM.
>
> It wasn't necessary to remove \chordGlissando from the text of the
> non-english docs, and it may even have been best not to do so.
>
> We need to keep compiling working, so if these docs had a snippet
> containing \chordGlissando, we would have needed to change that. But
> since the snippet was included as a file, it was sufficient to change
> the file.
>
> Please go ahead and push.
>
> Thanks,
>
>
> Carl
Thanks!
Pushed as 42f47af78202968f412a940f7ce9b3b1136fd236.
Cheers,
MS
Issue 4444066: Gets rid of chordGlissando.
(Closed)
Created 13 years ago by MikeSol
Modified 12 years, 12 months ago
Reviewers: carl.d.sorensen_gmail.com, mike_apollinemike.com
Base URL:
Comments: 0