Issue 4444066: Gets rid of chordGlissando.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4444066: Gets rid of chordGlissando. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by MikeSol

Modified:
14 years ago

Reviewers:
mike, carl.d.sorensen

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Gets rid of chordGlissando.

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -77 lines)			Patch
M	Documentation/de/notation/fretted-strings.itely	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Documentation/de/texidocs/chord-glissando-in-tablature.texidoc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Documentation/es/notation/fretted-strings.itely	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Documentation/es/texidocs/chord-glissando-in-tablature.texidoc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Documentation/notation/fretted-strings.itely	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Documentation/snippets/new/chord-glissando-in-tablature.ly	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	ly/music-functions-init.ly	View	1 chunk	+0 lines, -66 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Carl

LGTM. It wasn't necessary to remove \chordGlissando from the text of the non-english docs, and ...

14 years ago (2011-05-01 20:15:22 UTC) #2

mike_apollinemike.com

14 years ago (2011-05-01 20:32:24 UTC) #3

On May 1, 2011, at 1:15 PM, Carl.D.Sorensen@gmail.com wrote:

> LGTM.
> 
> It wasn't necessary to remove \chordGlissando from the text of the
> non-english docs, and it may even have been best not to do so.
> 
> We need to keep compiling working, so if these docs had a snippet
> containing \chordGlissando, we would have needed to change that.  But
> since the snippet was included as a file, it was sufficient to change
> the file.
> 
> Please go ahead and push.
> 
> Thanks,
> 
> 
> Carl

Thanks!

Pushed as 42f47af78202968f412a940f7ce9b3b1136fd236.

Cheers,
MS

Expand All Messages | Collapse All Messages