Issue 4442102: [pph] DECL_INITIAL instead of DECL_ARG_TYPE

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4442102: [pph] DECL_INITIAL instead of DECL_ARG_TYPE (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Lawrence Crowl

Modified:
12 years, 10 months ago

Reviewers:
Diego Novillo

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/pph/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	gcc/cp/pph-streamer-in.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	gcc/cp/pph-streamer-out.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Lawrence Crowl

In the pph file, save and restore DECL_INITIAL instead of just PARM_DECL DECL_ARG_TYPE. Index: gcc/cp/ChangeLog.pph ...

13 years, 11 months ago (2011-04-29 21:28:49 UTC) #1

In the pph file, save and restore DECL_INITIAL instead of just
PARM_DECL DECL_ARG_TYPE.

Index: gcc/cp/ChangeLog.pph

2011-04-29  Lawrence Crowl <crowl@google.com>

	* pph-streamer-out.c (pph_stream_write_tree): Write DECL_INITIAL
	instead of PARM_DECL DECL_ARG_TYPE.
	* pph-streamer-in.c (pph_stream_read_tree): Read DECL_INITIAL
	instead of PARM_DECL DECL_ARG_TYPE.

Index: gcc/cp/pph-streamer-in.c
===================================================================
--- gcc/cp/pph-streamer-in.c	(revision 173189)
+++ gcc/cp/pph-streamer-in.c	(working copy)
@@ -783,6 +783,8 @@ pph_stream_read_tree (struct lto_input_b
 
   if (DECL_P (expr))
     {
+      DECL_INITIAL (expr) = pph_input_tree (stream);
+
       if (TREE_CODE (expr) == FUNCTION_DECL
 	  || TREE_CODE (expr) == NAMESPACE_DECL
 	  || TREE_CODE (expr) == PARM_DECL
@@ -791,8 +793,6 @@ pph_stream_read_tree (struct lto_input_b
 	  pph_stream_read_lang_specific (stream, expr);
 	  if (TREE_CODE (expr) == FUNCTION_DECL)
 	    DECL_SAVED_TREE (expr) = pph_input_tree (stream);
-	  else if (TREE_CODE (expr) == PARM_DECL)
-	    DECL_ARG_TYPE (expr) = pph_input_tree (stream);
 	}
 
       if (TREE_CODE (expr) == TYPE_DECL)
Index: gcc/cp/pph-streamer-out.c
===================================================================
--- gcc/cp/pph-streamer-out.c	(revision 173189)
+++ gcc/cp/pph-streamer-out.c	(working copy)
@@ -787,6 +787,8 @@ pph_stream_write_tree (struct output_blo
 
   if (DECL_P (expr))
     {
+      pph_output_tree_or_ref_1 (stream, DECL_INITIAL (expr), ref_p, 3);
+
       if (TREE_CODE (expr) == FUNCTION_DECL
 	  || TREE_CODE (expr) == NAMESPACE_DECL
 	  || TREE_CODE (expr) == PARM_DECL
@@ -796,8 +798,6 @@ pph_stream_write_tree (struct output_blo
 
 	  if (TREE_CODE (expr) == FUNCTION_DECL)
 	    pph_output_tree_or_ref_1 (stream, DECL_SAVED_TREE (expr), ref_p, 3);
-	  else if (TREE_CODE (expr) == PARM_DECL)
-	    pph_output_tree_or_ref_1 (stream, DECL_ARG_TYPE (expr), ref_p, 3);
 	}
 
       if (TREE_CODE (expr) == TYPE_DECL)

--
This patch is available for review at http://codereview.appspot.com/4442102

Diego Novillo

13 years, 11 months ago (2011-04-29 21:34:51 UTC) #2

On Fri, Apr 29, 2011 at 17:28, Lawrence Crowl <crowl@google.com> wrote:
> In the pph file, save and restore DECL_INITIAL instead of just
> PARM_DECL DECL_ARG_TYPE.
>
> Index: gcc/cp/ChangeLog.pph
>
> 2011-04-29  Lawrence Crowl <crowl@google.com>
>
>        * pph-streamer-out.c (pph_stream_write_tree): Write DECL_INITIAL
>        instead of PARM_DECL DECL_ARG_TYPE.
>        * pph-streamer-in.c (pph_stream_read_tree): Read DECL_INITIAL
>        instead of PARM_DECL DECL_ARG_TYPE.

OK.


Diego.

Expand All Messages | Collapse All Messages