Issue 4440044: [google] Install cpu_defines.h

Issue 4440044: [google] Install cpu_defines.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Diego Novillo

Modified:
13 years, 6 months ago

Reviewers:
bkoz, paolo.carlini

CC:
dougkwan, libstdc++_gcc.gnu.org, gcc-patches_gcc.gnu.org

Visibility:
Public.

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -2 lines)			Patch
M	libstdc++-v3/ChangeLog.google-main	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	libstdc++-v3/include/Makefile.am	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	libstdc++-v3/include/Makefile.in	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Diego Novillo

I am committing this patch from Doug Kwan on google/main. This patch adds cpu_defines.h to ...

14 years ago (2011-04-16 20:27:42 UTC) #1

I am committing this patch from Doug Kwan on google/main.

This patch adds cpu_defines.h to the set of files to be installed.
Doug, could you describe why we need to do this?  Will you be
submitting this patch for trunk?

Tested on x86_64.  Committed on google/main.


Diego.

2011-03-15  Doug Kwan  <dougkwan@google.com>
    
    	Google ref 50044.
    
    	PR libstdc++/48123
    	* include/Makefile.am (install-freestanding-headers): Install
    	cpu_defines.h
    	* include/Makefile.in: Regenerate.

diff --git a/libstdc++-v3/include/Makefile.am b/libstdc++-v3/include/Makefile.am
index e7f1543..d3b44bc 100644
--- a/libstdc++-v3/include/Makefile.am
+++ b/libstdc++-v3/include/Makefile.am
@@ -1201,7 +1201,8 @@ endif
 install-freestanding-headers:
 	$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
 	$(mkinstalldirs) $(DESTDIR)${host_installdir}
-	for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h; do \
+	for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
+	  ${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
 	  $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
 	$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
 	$(INSTALL_DATA) ${std_builddir}/limits
$(DESTDIR)${gxx_include_dir}/${std_builddir}
diff --git a/libstdc++-v3/include/Makefile.in b/libstdc++-v3/include/Makefile.in
index a93b2ea..8a23c1b 100644
--- a/libstdc++-v3/include/Makefile.in
+++ b/libstdc++-v3/include/Makefile.in
@@ -1585,7 +1585,8 @@ ${pch3_output}: ${pch3_source} ${pch2_output}
 install-freestanding-headers:
 	$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
 	$(mkinstalldirs) $(DESTDIR)${host_installdir}
-	for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h; do \
+	for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
+	  ${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
 	  $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
 	$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
 	$(INSTALL_DATA) ${std_builddir}/limits
$(DESTDIR)${gxx_include_dir}/${std_builddir}


--
This patch is available for review at http://codereview.appspot.com/4440044

bkoz_redhat.com

> This patch adds cpu_defines.h to the set of files to be installed. > Doug, ...

14 years ago (2011-04-19 16:04:34 UTC) #2

Diego Novillo

On Tue, Apr 19, 2011 at 12:04, Benjamin Kosnik <bkoz@redhat.com> wrote: > >> This patch ...

14 years ago (2011-04-19 16:06:57 UTC) #3

dougkwan

This is used for a freestanding C++ library (i.e., we build libsupc++.a only). This is ...

14 years ago (2011-04-19 17:27:01 UTC) #4

This is used for a freestanding C++ library (i.e., we build
libsupc++.a only).  This is in trunk but for some reason it is not in
the 4.6 release.

-Doug

On Sat, Apr 16, 2011 at 1:27 PM, Diego Novillo <dnovillo@google.com> wrote:
> I am committing this patch from Doug Kwan on google/main.
>
> This patch adds cpu_defines.h to the set of files to be installed.
> Doug, could you describe why we need to do this?  Will you be
> submitting this patch for trunk?
>
> Tested on x86_64.  Committed on google/main.
>
>
> Diego.
>
> 2011-03-15  Doug Kwan  <dougkwan@google.com>
>
>        Google ref 50044.
>
>        PR libstdc++/48123
>        * include/Makefile.am (install-freestanding-headers): Install
>        cpu_defines.h
>        * include/Makefile.in: Regenerate.
>
> diff --git a/libstdc++-v3/include/Makefile.am
b/libstdc++-v3/include/Makefile.am
> index e7f1543..d3b44bc 100644
> --- a/libstdc++-v3/include/Makefile.am
> +++ b/libstdc++-v3/include/Makefile.am
> @@ -1201,7 +1201,8 @@ endif
>  install-freestanding-headers:
>        $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
>        $(mkinstalldirs) $(DESTDIR)${host_installdir}
> -       for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h;
do \
> +       for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
> +         ${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
>          $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
>        $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
>        $(INSTALL_DATA) ${std_builddir}/limits
$(DESTDIR)${gxx_include_dir}/${std_builddir}
> diff --git a/libstdc++-v3/include/Makefile.in
b/libstdc++-v3/include/Makefile.in
> index a93b2ea..8a23c1b 100644
> --- a/libstdc++-v3/include/Makefile.in
> +++ b/libstdc++-v3/include/Makefile.in
> @@ -1585,7 +1585,8 @@ ${pch3_output}: ${pch3_source} ${pch2_output}
>  install-freestanding-headers:
>        $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
>        $(mkinstalldirs) $(DESTDIR)${host_installdir}
> -       for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h;
do \
> +       for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
> +         ${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
>          $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
>        $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
>        $(INSTALL_DATA) ${std_builddir}/limits
$(DESTDIR)${gxx_include_dir}/${std_builddir}
>
>
> --
> This patch is available for review at http://codereview.appspot.com/4440044
>

paolo.carlini_oracle.com

On 04/19/2011 07:26 PM, Doug Kwan (關振德) wrote: > This is used for a freestanding ...

14 years ago (2011-04-19 17:37:08 UTC) #5

dougkwan

14 years ago (2011-04-19 18:08:52 UTC) #6

My bad.  I looked at the gcc-4.6.0 tarball and it is indeed there.

-Doug

On Tue, Apr 19, 2011 at 10:36 AM, Paolo Carlini
<paolo.carlini@oracle.com> wrote:
> On 04/19/2011 07:26 PM, Doug Kwan (關振德) wrote:
>>
>> This is used for a freestanding C++ library (i.e., we build
>> libsupc++.a only).  This is in trunk but for some reason it is not in
>> the 4.6 release.
>
> Why do you think so? For sure upon approval you committed it to the branch
> too, on March, 15th.
>
> Paolo.
>

Expand All Messages | Collapse All Messages