Issue 4439088: code review 4439088: http: fix racy test with a simpler version

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4439088: code review 4439088: http: fix racy test with a simpler version (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by bradfitz

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

http: fix racy test with a simpler version This was seen breaking the slow arm5 builder: http://godashboard.appspot.com/log/ec54ee302a70c07093e8f5c47454b3eb48768b77e1d8cc7943d8951f8b6696be The test was unnecessarily complex and didn't benefit from using httptest.Server. That just got in the way.

Patch Set 1 #

Patch Set 2 : diff -r 324929f8eeb8 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 324929f8eeb8 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 324929f8eeb8 https://go.googlecode.com/hg #

Patch Set 5 : diff -r 324929f8eeb8 https://go.googlecode.com/hg #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -41 lines)			Patch
	M	src/pkg/http/serve_test.go	View	1 2 3	1 chunk	+21 lines, -41 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

14 years ago (2011-05-02 19:59:50 UTC) #1

bradfitz

14 years ago (2011-05-02 20:01:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8c71c647d9f5 ***

http: fix racy test with a simpler version

This was seen breaking the slow arm5 builder:
http://godashboard.appspot.com/log/ec54ee302a70c07093e8f5c47454b3eb48768b77e1...

The test was unnecessarily complex and didn't benefit from
using httptest.Server. That just got in the way.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4439088

Expand All Messages | Collapse All Messages