Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(132)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4439045: code review 4439045: undo 4439044 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by rsc
Modified:
14 years ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

undo 4439044 cannot use regalloc with floating point on 386. will redo some other way.

Patch Set 1 #

Patch Set 2 : diff -r 80730c0ed22d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 80730c0ed22d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -66 lines) Patch
M src/cmd/gc/cplx.c View 1 2 chunks +3 lines, -16 lines 0 comments Download
R test/fixedbugs/bug329.go View 1 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years ago (2011-04-15 23:17:13 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=81d520200d30 *** undo 4439044 cannot use regalloc with floating point on 386. ...
14 years ago (2011-04-15 23:17:24 UTC) #2
ken3
14 years ago (2011-04-18 11:47:45 UTC) #3 
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b