Issue 4439042: code review 4439042: misc/goplay: fix Tab and Shift+Enter in Firefox.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4439042: code review 4439042: misc/goplay: fix Tab and Shift+Enter in Firefox. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by dchest

Modified:
14 years ago

Reviewers:

CC:
adg, dsymonds, golang-dev

Visibility:
Public.

Description

misc/goplay: fix Tab and Shift+Enter in Firefox. Fixes issue 1633.

Patch Set 2 : diff -r e310f6fc31f5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e310f6fc31f5 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 86ada3d3de44 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	misc/goplay/goplay.go	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dchest

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-04-15 15:11:45 UTC) #1

dsymonds

http://codereview.appspot.com/4439042/diff/5001/misc/goplay/goplay.go File misc/goplay/goplay.go (right): http://codereview.appspot.com/4439042/diff/5001/misc/goplay/goplay.go#newcode239 misc/goplay/goplay.go:239: var e = window.event ? window.event : event; more ...

14 years ago (2011-04-15 23:54:48 UTC) #2

dchest

PTAL http://codereview.appspot.com/4439042/diff/5001/misc/goplay/goplay.go File misc/goplay/goplay.go (right): http://codereview.appspot.com/4439042/diff/5001/misc/goplay/goplay.go#newcode239 misc/goplay/goplay.go:239: var e = window.event ? window.event : event; ...

14 years ago (2011-04-16 06:47:17 UTC) #3

adg

LGTM On 16 April 2011 16:47, <dchest@gmail.com> wrote: > PTAL > > > http://codereview.appspot.com/4439042/diff/5001/misc/goplay/goplay.go > ...

14 years ago (2011-04-16 08:44:54 UTC) #4

adg

14 years ago (2011-04-16 08:44:59 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=ab386ee780c0 ***

misc/goplay: fix Tab and Shift+Enter in Firefox.

Fixes issue 1633.

R=adg, dsymonds
CC=golang-dev
http://codereview.appspot.com/4439042

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages