Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Issue 4438054: Doc: writing music events to a .notes file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Graham Percival (old account)
Modified:
12 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: writing music events to a .notes file.

Patch Set 1 #

Total comments: 12

Patch Set 2 : fix language #

Total comments: 4

Patch Set 3 : more fix language. #

Patch Set 4 : use 'rest' arguments. #

Patch Set 5 : oops, undo bad upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -30 lines) Patch
M Documentation/notation/input.itely View 1 2 4 4 chunks +99 lines, -30 lines 0 comments Download

Messages

Total messages: 7
Reinhold
http://codereview.appspot.com/4438054/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4438054/diff/1/Documentation/notation/input.itely#newcode2386 Documentation/notation/input.itely:2386: The syntax is a tab-delimited line, with at two ...
13 years ago (2011-04-19 11:33:32 UTC) #1
pkx166h
minor stuff, one missing word. http://codereview.appspot.com/4438054/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4438054/diff/1/Documentation/notation/input.itely#newcode2329 Documentation/notation/input.itely:2329: Displaying a music expression ...
13 years ago (2011-04-19 11:36:41 UTC) #2
Graham Percival (old account)
thanks, updated. http://codereview.appspot.com/4438054/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4438054/diff/1/Documentation/notation/input.itely#newcode2329 Documentation/notation/input.itely:2329: Displaying a music expression in LilyPond notation ...
13 years ago (2011-04-19 12:15:23 UTC) #3
pkx166h
LGTM thanks.
13 years ago (2011-04-19 13:38:29 UTC) #4
Trevor Daniels
LGTM, apart from a couple of nitpicks. Trevor http://codereview.appspot.com/4438054/diff/2002/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4438054/diff/2002/Documentation/notation/input.itely#newcode2373 Documentation/notation/input.itely:2373: you ...
13 years ago (2011-04-19 16:06:48 UTC) #5
Graham Percival (old account)
thanks, updated. http://codereview.appspot.com/4438054/diff/2002/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4438054/diff/2002/Documentation/notation/input.itely#newcode2373 Documentation/notation/input.itely:2373: you have multiple unnamed staffs, the events ...
13 years ago (2011-04-20 18:55:01 UTC) #6
Graham Percival (old account)
12 years, 10 months ago (2011-06-08 19:10:01 UTC) #7
thanks, pushed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b