Issue 4437079: code review 4437079: goprotobuf: push out internal changes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4437079: code review 4437079: goprotobuf: push out internal changes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by dsymonds

Modified:
14 years, 6 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

goprotobuf: push out internal changes. - group text parsing and formatting - foreign extension types

Patch Set 1 #

Patch Set 2 : diff -r 7d7a616db83e https://goprotobuf.googlecode.com/hg #

Patch Set 3 : diff -r 7d7a616db83e https://goprotobuf.googlecode.com/hg #

Patch Set 4 : diff -r 7d7a616db83e https://goprotobuf.googlecode.com/hg #

Patch Set 5 : diff -r 7d7a616db83e https://goprotobuf.googlecode.com/hg #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -45 lines)			Patch
M	compiler/generator/generator.go	View	1	3 chunks	+16 lines, -2 lines	0 comments	Download
M	compiler/testdata/Makefile	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A	compiler/testdata/extension_extra.proto	View	1 2 3	1 chunk	+38 lines, -0 lines	0 comments	Download
M	compiler/testdata/extension_user.proto	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download
M	compiler/testdata/test.proto	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	compiler/testdata/test.pb.go.golden	View	1 2 3	2 chunks	+10 lines, -0 lines	0 comments	Download
M	proto/testdata/test.proto	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	1 2 3	4 chunks	+15 lines, -5 lines	0 comments	Download
M	proto/text.go	View	1	8 chunks	+31 lines, -15 lines	0 comments	Download
M	proto/text_parser.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	proto/text_parser_test.go	View	1	8 chunks	+30 lines, -19 lines	0 comments	Download
M	proto/text_test.go	View	1	3 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://goprotobuf.googlecode.com/hg

14 years, 6 months ago (2011-04-28 07:45:03 UTC) #1

dsymonds

*** Submitted as http://code.google.com/p/goprotobuf/source/detail?r=44f4e3da3f95 *** goprotobuf: push out internal changes. - group text parsing and ...

14 years, 6 months ago (2011-04-28 08:08:49 UTC) #2

LGTM

Expand All Messages | Collapse All Messages