Issue 4436074: code review 4436074: http/spdy: add type to FlagClearPreviouslyPersistedSett...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4436074: code review 4436074: http/spdy: add type to FlagClearPreviouslyPersistedSett... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Ross Light

Modified:
14 years ago

Reviewers:
r2

CC:
rsc, bradfitz, golang-dev

Visibility:
Public.

Description

http/spdy: add type to FlagClearPreviouslyPersistedSettings constant

Patch Set 2 : diff -r 808ef4c8dda6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 808ef4c8dda6 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/http/spdy/protocol.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Ross Light

Hello rsc, bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-02 19:40:34 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=c22a3a37125f *** http/spdy: add type to FlagClearPreviouslyPersistedSettings constant R=rsc, bradfitz CC=golang-dev http://codereview.appspot.com/4436074 ...

14 years ago (2011-05-04 19:01:45 UTC) #3

Ross Light

On 2011/05/04 19:01:15, rsc wrote: > What a long name. Believe it or not, I ...

14 years ago (2011-05-05 01:19:35 UTC) #4

14 years ago (2011-05-05 14:55:00 UTC) #5

On May 4, 2011, at 6:19 PM, rlight2@gmail.com wrote:

> On 2011/05/04 19:01:15, rsc wrote:
>> What a long name.
> 
> Believe it or not, I shortened it from the spec name. :D
> 
> http://www.chromium.org/spdy/spdy-protocol/spdy-protocol-draft2#TOC-SETTINGS
> 
> http://codereview.appspot.com/4436074/

 FLAG_SETTINGS_CLEAR_PREVIOUSLY_PERSISTED_SETTINGS is indeed a very long name
for '1'.

it takes extra work to get an adverb into a name. even more to make one that
adds zero meaning. (if the settings weren't set previously, when were they set
and why do you need to clear them?)

currently at this point in time i think this will be very useful going forward.
nice work, everyone.

-rob

Expand All Messages | Collapse All Messages