Issue 4436072: code review 4436072: runtime, sync/atomic: fix arm cas

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4436072: code review 4436072: runtime, sync/atomic: fix arm cas (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 4 months ago

Reviewers:

CC:
dave_cheney.net, golang-dev

Visibility:
Public.

Description

runtime, sync/atomic: fix arm cas Works around bug in kernel implementation on old ARM5 kernels. Bug was fixed on 26 Nov 2007 (between 2.6.23 and 2.6.24) but old kernels persist. Fixes issue 1750.

Patch Set 1 #

Patch Set 2 : diff -r 8d78d5e69093 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8d78d5e69093 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9266c53a8fc0 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9266c53a8fc0 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 099dd59d3976 https://go.googlecode.com/hg #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
	M	src/pkg/runtime/linux/arm/sys.s	View	1 2 3	1 chunk	+13 lines, -2 lines	0 comments	Download
	M	src/pkg/sync/atomic/asm_linux_arm.s	View	1 2 3 4	2 chunks	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dave_cheney.net

225 successful runs of chan/doubleselect.go without failure (previously 22%). I'm going to move on to ...

14 years, 5 months ago (2011-05-02 02:51:22 UTC) #1

rsc

Hello dfc, golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 5 months ago (2011-05-02 03:24:41 UTC) #2

dave_cheney.net

10 rounds of test/run completed successfully as well.

14 years, 5 months ago (2011-05-02 04:36:36 UTC) #3

rsc

Hello dfc, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 5 months ago (2011-05-02 12:37:15 UTC) #4

rsc

This new implementation does not do any extra work in the no-conflict case, which should ...

14 years, 5 months ago (2011-05-02 12:41:16 UTC) #5

rsc

14 years, 5 months ago (2011-05-02 14:49:21 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=e280d98747be ***

runtime, sync/atomic: fix arm cas

Works around bug in kernel implementation on old ARM5 kernels.
Bug was fixed on 26 Nov 2007 (between 2.6.23 and 2.6.24) but
old kernels persist.

Fixes issue 1750.

R=dfc, golang-dev
CC=golang-dev
http://codereview.appspot.com/4436072

Expand All Messages | Collapse All Messages