code review 4436060: gopack: preserve safe flag when not adding unsafe objec...

gopack: preserve safe flag when not adding unsafe objects to archive

[rsc, 2011-04-27 02:52:00]

Hello dsymonds (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-04-27 04:42:55]

LGTM

The string handling seems a little flimsy, but I guess it'll do.

[rsc, 2011-04-27 04:45:32]

On Wed, Apr 27, 2011 at 00:42, David Symonds <dsymonds@golang.org> wrote:
> LGTM
>
> The string handling seems a little flimsy, but I guess it'll do.

Do you see any problems?

[dsymonds, 2011-04-27 04:58:45]

On Wed, Apr 27, 2011 at 2:45 PM, Russ Cox <rsc@golang.org> wrote:

> On Wed, Apr 27, 2011 at 00:42, David Symonds <dsymonds@golang.org> wrote:
>> LGTM
>>
>> The string handling seems a little flimsy, but I guess it'll do.
>
> Do you see any problems?

I don't see any errors in the code, but it's going to be error prone
to change if the package format is ever modified.
It's also untested, but the same goes for a lot of this code.

Submit as is.

[rsc, 2011-04-27 13:20:37]

> I don't see any errors in the code, but it's going to be error prone
> to change if the package format is ever modified.

I think you're objecting to the use of strings at all.  Sorry.

Russ

[rsc, 2011-04-27 13:21:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=66fd38761bab ***

gopack: preserve safe flag when not adding unsafe objects to archive

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/4436060