Issue 4435059: code review 4435059: syscall: correct Windows CreateProcess input parameters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4435059: code review 4435059: syscall: correct Windows CreateProcess input parameters (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by brainman

Modified:
13 years, 11 months ago

Reviewers:

CC:
golang-dev, rsc, peterGo, r

Visibility:
Public.

Description

syscall: correct Windows CreateProcess input parameters Fixes issue 1718.

Patch Set 1 #

Patch Set 2 : diff -r 1405ca30d8be https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1405ca30d8be https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 79deef5a2706 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
M	src/cmd/gotest/gotest.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exec/exec_test.go	View	1	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/pkg/syscall/exec_windows.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com (cc: peterGo), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-04-20 12:41:40 UTC) #1

rsc

LGTM Please delete 'Fixes issue 1719.' since this code is not about the crash printing. ...

13 years, 11 months ago (2011-04-20 13:15:11 UTC) #2

peterGo

LGTM From both the MSYS and the Windows command windows, if a diff.exe program is ...

13 years, 11 months ago (2011-04-20 14:45:09 UTC) #3

brainman

13 years, 11 months ago (2011-04-21 00:36:33 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=bc9e9e3e43e2 ***

syscall: correct Windows CreateProcess input parameters

Fixes issue 1718.

R=golang-dev, rsc, peterGo, r
CC=golang-dev
http://codereview.appspot.com/4435059

Expand All Messages | Collapse All Messages