Issue 4433099: code review 4433099: [release-branch.r57] reflect: allow unexported key in V...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4433099: code review 4433099: [release-branch.r57] reflect: allow unexported key in V... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by rsc

Modified:
13 years ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

[release-branch.r57] reflect: allow unexported key in Value.MapIndex ««« CL 4444087 / 9abf81a9df90 reflect: allow unexported key in Value.MapIndex Fixes issue 1748. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4444087 »»»

Patch Set 1 #

Patch Set 2 : diff -r b687ae9f75fd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b687ae9f75fd https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b687ae9f75fd https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
	M	src/pkg/reflect/all_test.go	View	1 2 3	2 chunks	+21 lines, -1 line	0 comments	Download
	M	src/pkg/reflect/value.go	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2011-05-03 14:40:21 UTC) #1

rsc

13 years ago (2011-05-03 15:09:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=1991b9fcc5c5 ***

[release-branch.r57] reflect: allow unexported key in Value.MapIndex

««« CL 4444087 / 9abf81a9df90
reflect: allow unexported key in Value.MapIndex

Fixes issue 1748.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4444087
»»»

R=r, r2
CC=golang-dev
http://codereview.appspot.com/4433099

Expand All Messages | Collapse All Messages