Issue 4433094: code review 4433094: http: new error for reading a body after it's been closed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4433094: code review 4433094: http: new error for reading a body after it's been closed (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bradfitz

Modified:
13 years ago

Reviewers:
eh

CC:
adg, golang-dev

Visibility:
Public.

Description

http: new error for reading a body after it's been closed

Patch Set 1 #

Patch Set 2 : diff -r 255d03eb8745 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 255d03eb8745 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 255d03eb8745 https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	src/pkg/http/transfer.go	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2011-05-01 02:33:38 UTC) #1

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=e30213b07276 *** http: new error for reading a body after it's been ...

13 years ago (2011-05-01 02:54:14 UTC) #3

> +var ErrBodyReadAferClose = os.NewError("http: invalid Read on closed request Body") s/Afer/After/ ? Chris -- ...

13 years ago (2011-05-01 06:25:02 UTC) #4

adg

13 years ago (2011-05-01 06:28:35 UTC) #5

On 30 April 2011 23:25, chris dollin <ehog.hedge@googlemail.com> wrote:
>> +var ErrBodyReadAferClose = os.NewError("http: invalid Read on closed request
Body")
>
> s/Afer/After/ ?

Sigh. Good catch. :|

Expand All Messages | Collapse All Messages