Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 4433079: [google] Use R_ARM_GOT_PREL to simplify global address loading from GOT

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by carrot
Modified:
12 years, 11 months ago
Reviewers:
davidxl, dougkwan, Diego Novillo, iant2, rearnsha
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -0 lines) Patch
M gcc/Makefile.in View 2 chunks +3 lines, -0 lines 0 comments Download
M gcc/config/arm/arm.c View 4 chunks +219 lines, -0 lines 0 comments Download
M gcc/config/arm/arm.md View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/hooks.h View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/hooks.c View 1 chunk +7 lines, -0 lines 1 comment Download
M gcc/passes.c View 1 chunk +1 line, -0 lines 0 comments Download
A gcc/simplify-got.c View 1 chunk +196 lines, -0 lines 2 comments Download
M gcc/target.def View 1 chunk +62 lines, -0 lines 0 comments Download
A gcc/testsuite/gcc.target/arm/got1.c View 1 chunk +10 lines, -0 lines 0 comments Download
A gcc/testsuite/gcc.target/arm/got2.c View 1 chunk +11 lines, -0 lines 0 comments Download
M gcc/timevar.def View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/tree-pass.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9
carrot
Hi This patch is for google/main. The bug http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43129 describes how arm backend generates ineffecient ...
12 years, 11 months ago (2011-04-28 06:50:47 UTC) #1
Diego Novillo
I only have some stylistic comments for this patch. The new pass looks OK to ...
12 years, 11 months ago (2011-04-28 14:08:05 UTC) #2
Diego Novillo
Will you be proposing this patch for trunk as well? Diego.
12 years, 11 months ago (2011-04-28 14:26:21 UTC) #3
carrot
On Thu, Apr 28, 2011 at 10:08 PM, <dnovillo@google.com> wrote: > I only have some ...
12 years, 11 months ago (2011-04-29 03:17:29 UTC) #4
carrot
Yes, after porting it to google/main. Carrot On Thu, Apr 28, 2011 at 10:26 PM, ...
12 years, 11 months ago (2011-04-29 03:18:58 UTC) #5
davidxl
Ok for google/main. David On Thu, Apr 28, 2011 at 8:18 PM, Carrot Wei <carrot@google.com> ...
12 years, 11 months ago (2011-04-29 04:20:16 UTC) #6
carrot
On Fri, Apr 29, 2011 at 11:17 AM, Carrot Wei <carrot@google.com> wrote: > On Thu, ...
12 years, 11 months ago (2011-04-29 05:24:32 UTC) #7
Diego Novillo
On Fri, Apr 29, 2011 at 01:24, Carrot Wei <carrot@google.com> wrote: >>> http://codereview.appspot.com/4433079/diff/1/gcc/hooks.c#newcode287 >>> gcc/hooks.c:287: ...
12 years, 11 months ago (2011-04-29 20:45:06 UTC) #8
rearnsha_arm.com
12 years, 11 months ago (2011-05-03 14:59:42 UTC) #9
On Fri, 2011-04-29 at 11:18 +0800, Carrot Wei wrote:
> Yes, after porting it to google/main.
> 
> Carrot
> 
> On Thu, Apr 28, 2011 at 10:26 PM, Diego Novillo <dnovillo@google.com> wrote:
> > Will you be proposing this patch for trunk as well?
> >
> >
> > Diego.
> >

At the very least a trunk version of this patch will need to deal with
assembly formats that do not support this relocation (I think pe-coff is
one such format).  


R.


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b