code review 4433066: reflect: rename Typeof, NewValue -> TypeOf, ValueOf

reflect: rename Typeof, NewValue -> TypeOf, ValueOf

[rsc, 2011-04-23 14:40:20]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-04-23 14:44:09]

When we discussed this change we talked about
introducing a variant of reflect.Zero that returned an
addressable zero value, a shorthand to let people write

    reflect.XXX(t)

instead of

    reflect.New(t).Elem()

I couldn't come up with a reasonable name so I left it out.
Any name I can think of sounds like it would do the same
thing as New, and I'm pretty sure that New has the right
signature (same as Go's new).

Russ

[r, 2011-04-23 15:11:45]

LGTM

[bradfitz, 2011-04-24 00:22:46]

Are unsafe.Sizeof and unsafe.Typeof getting capital "Of" too?

On Sat, Apr 23, 2011 at 7:40 AM, <rsc@golang.org> wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> reflect: rename Typeof, NewValue -> TypeOf, ValueOf
>
> Please review this at http://codereview.appspot.com/4433066/
>
> Affected files:
>  M src/pkg/reflect/all_test.go
>  M src/pkg/reflect/deepequal.go
>  M src/pkg/reflect/set_test.go
>  M src/pkg/reflect/type.go
>  M src/pkg/reflect/value.go
>
>
>

[r, 2011-04-24 05:46:00]

not in this round, and probably never.  for arbitrary reasons, the
lowest level stuff is all lower case (with initial cap for
visibility).

unsafe is very very low.

-rob

[rsc, 2011-04-25 17:39:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=b32a200c7f83 ***

reflect: rename Typeof, NewValue -> TypeOf, ValueOf

R=r, bradfitzgo
CC=golang-dev
http://codereview.appspot.com/4433066