Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 4433060: code review 4433060: 9term, acme: autoscroll (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by rsc
Modified:
13 years, 8 months ago
Reviewers:
CC:
r, r2
Visibility:
Public.

Description

9term, acme: autoscroll Ignore scroll/noscroll window setting. Instead, scroll when the write begins in or immediately after the displayed window content. In the new scrolling discipline, executing "Noscroll" is replaced by typing Page Up or using the mouse to scroll higher in the buffer, and executing "Scroll" is replaced by typing End or using the mouse to scroll to the bottom of the buffer.

Patch Set 1 #

Patch Set 2 : diff -r 87537a3b265c rsc/plan9port #

Patch Set 3 : diff -r 1b3e32c70984 rsc/plan9port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -72 lines) Patch
M man/man1/9term.1 View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M man/man1/acme.1 View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M man/man1/rio.1 View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M man/man4/acme.4 View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M src/cmd/9term/9term.c View 1 2 8 chunks +4 lines, -15 lines 0 comments Download
M src/cmd/9term/dat.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/cmd/9term/fns.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/9term/win.c View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M src/cmd/9term/wind.c View 1 2 5 chunks +5 lines, -8 lines 0 comments Download
M src/cmd/acme/dat.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/acme/exec.c View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/acme/xfid.c View 1 2 3 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 10
r
shouldn't you also delete the scroll/noscroll variable as well, then?
13 years, 9 months ago (2011-04-20 21:20:40 UTC) #1
r
a flaw in this is that it is now impossible to disable scrolling in an ...
13 years, 9 months ago (2011-04-20 21:21:46 UTC) #2
rsc
> shouldn't you also delete scroll/noscroll yes, and from win too. this is just a ...
13 years, 9 months ago (2011-04-20 22:07:55 UTC) #3
r2
i think it's worth rolling out. if we don't like it, we unroll. -rob
13 years, 9 months ago (2011-04-20 22:15:07 UTC) #4
r2
by the way, i don't know what Home is on my keyboard. -rob
13 years, 9 months ago (2011-04-20 22:15:20 UTC) #5
rsc
On Wed, Apr 20, 2011 at 18:15, Rob 'Commander' Pike <r@google.com> wrote: > by the ...
13 years, 9 months ago (2011-04-20 22:20:38 UTC) #6
r2
On Apr 20, 2011, at 3:20 PM, Russ Cox wrote: > On Wed, Apr 20, ...
13 years, 9 months ago (2011-04-20 22:21:44 UTC) #7
rsc
> thanks. > > why not option or command or control or shift left-arrow? > ...
13 years, 9 months ago (2011-04-20 22:23:50 UTC) #8
rsc
Hello r, r2, I'd like you to review this change to rsc/plan9port
13 years, 8 months ago (2011-04-27 17:18:06 UTC) #9
rsc
13 years, 8 months ago (2011-04-27 17:18:13 UTC) #10
*** Submitted as 16d4081236af ***

9term, acme: autoscroll

Ignore scroll/noscroll window setting.
Instead, scroll when the write begins in
or immediately after the displayed window content.

In the new scrolling discipline, executing
"Noscroll" is replaced by typing Page Up or
using the mouse to scroll higher in the buffer,
and executing "Scroll" is replaced by typing End
or using the mouse to scroll to the bottom of
the buffer.

R=r, r2
http://codereview.appspot.com/4433060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b