Issue 4433056: code review 4433056: crypto/x509: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4433056: code review 4433056: crypto/x509: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by agl1

Modified:
14 years ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

crypto/x509: fix build This pulls in changes that should have been in 3faf9d0c10c0, but weren't because x509.go was part of another changelist. TBR=bradfitzgo

Patch Set 1 #

Patch Set 2 : diff -r 3faf9d0c10c0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3faf9d0c10c0 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -58 lines)			Patch
	M	src/pkg/crypto/x509/x509.go	View	1	2 chunks	+0 lines, -58 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello bradfitzgo (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-04-19 14:11:36 UTC) #1

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=e0548d3e4591 *** crypto/x509: fix build This pulls in changes that should have ...

14 years ago (2011-04-19 14:11:46 UTC) #2

bradfitz

14 years ago (2011-04-19 15:32:49 UTC) #3

LGTM

On Tue, Apr 19, 2011 at 7:11 AM, <agl@golang.org> wrote:

> *** Submitted as
> http://code.google.com/p/go/source/detail?r=e0548d3e4591 ***
>
>
> crypto/x509: fix build
>
> This pulls in changes that should have been in 3faf9d0c10c0, but
> weren't because x509.go was part of another changelist.
>
> TBR=bradfitzgo
>
> R=bradfitzgo
> CC=golang-dev
>
> http://codereview.appspot.com/4433056
>
>
> http://codereview.appspot.com/4433056/
>

Expand All Messages | Collapse All Messages