Issue 4433044: MIDI: partcombine regtest needs skips (issue 1609)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4433044: MIDI: partcombine regtest needs skips (issue 1609) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Keith

Modified:
13 years ago

Reviewers:
carl.d.sorensen

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

MIDI: partcombine regtest needs skips (issue 1609)

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	input/regression/midi/partcombine.ly	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Carl

The patch seems appropriate. However, I think there should be more patches, IIUC. There are ...

13 years ago (2011-04-16 14:33:10 UTC) #1

Keith

13 years ago (2011-04-16 18:46:06 UTC) #2

On 2011/04/16 14:33:10, Carl wrote:
> I think these comments should go away.

Agreed. I looked over the new midi regression tests again; these comments are
leftovers from copy/paste, and could only confuse us, so they are gone.

This patch affects only a regression test, so I'll push now and close this
rietveld issue.

Expand All Messages | Collapse All Messages